kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-16 17:33:45 +00:00
Code Issues Projects Releases Wiki Activity

Catch import routines that submit integers.

Browse Source
This commit is contained in:
James Cole
2019-11-09 16:53:04 +01:00
parent 34e7455d67
commit dc0e8528c8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Factory/TransactionJournalFactory.php
View File

@@ -332,7 +332,7 @@ class TransactionJournalFactory
$transactionFactory->setCurrency($sourceCurrency); $transactionFactory->setCurrency($sourceCurrency);
$transactionFactory->setForeignCurrency($sourceForeignCurrency); $transactionFactory->setForeignCurrency($sourceForeignCurrency);
$transactionFactory->setReconciled($row['reconciled'] ?? false); $transactionFactory->setReconciled($row['reconciled'] ?? false);
$transactionFactory->createNegative((string)$row['amount'], $row['foreign_amount']); $transactionFactory->createNegative((string)$row['amount'], (string)$row['foreign_amount']);
// and the destination one: // and the destination one:
/** @var TransactionFactory $transactionFactory */ /** @var TransactionFactory $transactionFactory */
@@ -343,7 +343,7 @@ class TransactionJournalFactory
$transactionFactory->setCurrency($destCurrency); $transactionFactory->setCurrency($destCurrency);
$transactionFactory->setForeignCurrency($destForeignCurrency); $transactionFactory->setForeignCurrency($destForeignCurrency);
$transactionFactory->setReconciled($row['reconciled'] ?? false); $transactionFactory->setReconciled($row['reconciled'] ?? false);
$transactionFactory->createPositive((string)$row['amount'], $row['foreign_amount']); $transactionFactory->createPositive((string)$row['amount'], (string)$row['foreign_amount']);
// verify that journal has two transactions. Otherwise, delete and cancel. // verify that journal has two transactions. Otherwise, delete and cancel.
// TODO this can't be faked so it can't be tested. // TODO this can't be faked so it can't be tested.