From dc0e8528c8f4ba016c0774cadb92ac303a0413ac Mon Sep 17 00:00:00 2001 From: James Cole Date: Sat, 9 Nov 2019 16:53:04 +0100 Subject: [PATCH] Catch import routines that submit integers. --- app/Factory/TransactionJournalFactory.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Factory/TransactionJournalFactory.php b/app/Factory/TransactionJournalFactory.php index 4bd58b8dcf..95c25af707 100644 --- a/app/Factory/TransactionJournalFactory.php +++ b/app/Factory/TransactionJournalFactory.php @@ -332,7 +332,7 @@ class TransactionJournalFactory $transactionFactory->setCurrency($sourceCurrency); $transactionFactory->setForeignCurrency($sourceForeignCurrency); $transactionFactory->setReconciled($row['reconciled'] ?? false); - $transactionFactory->createNegative((string)$row['amount'], $row['foreign_amount']); + $transactionFactory->createNegative((string)$row['amount'], (string)$row['foreign_amount']); // and the destination one: /** @var TransactionFactory $transactionFactory */ @@ -343,7 +343,7 @@ class TransactionJournalFactory $transactionFactory->setCurrency($destCurrency); $transactionFactory->setForeignCurrency($destForeignCurrency); $transactionFactory->setReconciled($row['reconciled'] ?? false); - $transactionFactory->createPositive((string)$row['amount'], $row['foreign_amount']); + $transactionFactory->createPositive((string)$row['amount'], (string)$row['foreign_amount']); // verify that journal has two transactions. Otherwise, delete and cancel. // TODO this can't be faked so it can't be tested.