kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-16 09:22:33 +00:00
Code Issues Projects Releases Wiki Activity

Make sure amounts are always positive.

Browse Source
This commit is contained in:
James Cole
2019-09-04 10:12:33 +02:00
parent d23656aac9
commit 2cda6eba94
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/Transformers/TransactionGroupTransformer.php
View File

@@ -274,14 +274,11 @@ class TransactionGroupTransformer extends AbstractTransformer
$row = new NullArrayObject($transaction); $row = new NullArrayObject($transaction);
// amount: // amount:
$type = $row['transaction_type_type'] ?? TransactionType::WITHDRAWAL; $type = $row['transaction_type_type'] ?? TransactionType::WITHDRAWAL;
$amount = $row['amount'] ?? '0'; $amount = app('steam')->positive($row['amount'] ?? '0');
if (TransactionType::WITHDRAWAL !== $type) {
$amount = bcmul($amount, '-1');
}
$foreignAmount = null; $foreignAmount = null;
if (null !== $row['foreign_amount']) { if (null !== $row['foreign_amount']) {
$foreignAmount = TransactionType::WITHDRAWAL !== $type ? bcmul($row['foreign_amount'], '-1') : $row['foreign_amount']; // @codeCoverageIgnore $foreignAmount = app('steam')->positive($row['foreign_amount']);
} }
$metaFieldData = $this->groupRepos->getMetaFields((int)$row['transaction_journal_id'], $this->metaFields); $metaFieldData = $this->groupRepos->getMetaFields((int)$row['transaction_journal_id'], $this->metaFields);