From 2cda6eba94a257854d2d321f79879a296c1b08ef Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Wed, 4 Sep 2019 10:12:33 +0200
Subject: [PATCH] Make sure amounts are always positive.

---
 app/Transformers/TransactionGroupTransformer.php | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/app/Transformers/TransactionGroupTransformer.php b/app/Transformers/TransactionGroupTransformer.php
index 62cb133acd..f0052840ad 100644
--- a/app/Transformers/TransactionGroupTransformer.php
+++ b/app/Transformers/TransactionGroupTransformer.php
@@ -274,14 +274,11 @@ class TransactionGroupTransformer extends AbstractTransformer
             $row = new NullArrayObject($transaction);
 
             // amount:
-            $type   = $row['transaction_type_type'] ?? TransactionType::WITHDRAWAL;
-            $amount = $row['amount'] ?? '0';
-            if (TransactionType::WITHDRAWAL !== $type) {
-                $amount = bcmul($amount, '-1');
-            }
+            $type          = $row['transaction_type_type'] ?? TransactionType::WITHDRAWAL;
+            $amount        = app('steam')->positive($row['amount'] ?? '0');
             $foreignAmount = null;
             if (null !== $row['foreign_amount']) {
-                $foreignAmount = TransactionType::WITHDRAWAL !== $type ? bcmul($row['foreign_amount'], '-1') : $row['foreign_amount']; // @codeCoverageIgnore
+                $foreignAmount = app('steam')->positive($row['foreign_amount']);
             }
 
             $metaFieldData = $this->groupRepos->getMetaFields((int)$row['transaction_journal_id'], $this->metaFields);