Neeraj Gupta
943e79464a
Lint fixes
2024-11-20 14:41:19 +05:30
Neeraj Gupta
f38ee6369f
[mob[ Added doc for mobile translations + added 2 new source string… ( #4040 )
...
This is my first contribution and I wanted to start with something
'simple'. My goal is to further contribute to the translation of Ente
photos. I am trying to understand that process which is not yet entirely
clear to me, especially when it comes to which files must be (or do not
need to be) generated.
## Description
As a first (small) step, I have:
- created 2 new source strings ('collaboratorsSuccessfullyAdded' and
'viewersSuccessfullyAdded') that replace hardcoded text in the
"add_a_participant" page.
- Created draft of a documentation for translations on mobile app (based
on the doc for web app)
## Tests
Tested on my Pixel 6a
Built with :
- Flutter 3.24.3
- JDK 17.0.2
- Gradle 7.2
## Questions
- I have manually updated the `l10n.dart` file (using existing similar
strings ) but I guess it should be automatically generated from the
`intl_en.arb` file, correct? If so, is it something anyone can do and
can we add the step in the doc?
- Should the other languages be updated as well in that commit, or will
they only be updated via the Github Crowdin action ? Looking at the
existing PR, it seems like they might need to be updated as well in the
commit.
2024-11-20 14:19:10 +05:30
Neeraj Gupta
b0b527d2ea
[mob] Clean up
2024-11-19 18:12:58 +05:30
Neeraj Gupta
572f2aff88
[mob] Hide merge section if no suggestion
2024-11-19 17:55:41 +05:30
Neeraj Gupta
a2d022f751
[mob] UI Changes
2024-11-19 17:53:23 +05:30
Neeraj Gupta
7e7d53fbaf
[mob] Rename icons and action name for people bar
2024-11-19 17:22:20 +05:30
Neeraj Gupta
c25310059a
Merge remote-tracking branch 'origin/main' into save_contact
2024-11-19 16:50:11 +05:30
Laurens Priem
8b07db8a73
Ml sync fix ( #4027 )
...
## Description
Remotely safe faceIDs of a certain person that are rejected by the user.
2024-11-19 13:43:45 +05:30
Prateek Sunal
68ac9cbe26
fix: remove unwanted code
2024-11-19 13:42:18 +05:30
simondubrulle
bdf1023612
Merge pull request #1 from simondubrulle/main
...
Synced with main
2024-11-19 07:31:20 +01:00
Neeraj Gupta
18cf3f2e60
[mob] Add new screen for save person
2024-11-19 11:53:06 +05:30
Neeraj Gupta
14adea59bf
Use super
2024-11-19 10:57:40 +05:30
ashilkn
e7d6ea0f3a
[mob][photos] Cancel subscription to linkStream in passkey page after use
2024-11-18 19:02:05 +05:30
ashilkn
a86b6dddd4
[mob][photos] Resolve merge conflicts and merge main
2024-11-18 18:24:05 +05:30
ashilkn
f42ae367dc
[mob][photos] Fix loading and error state of 'all' screen of people section
2024-11-18 11:01:11 +05:30
ashilkn
4f86ca9415
Merge branch 'main' into faces_UI_enhancement
2024-11-18 10:51:04 +05:30
ashilkn
47b668a82a
[mob][photos] Minor animation tweaks:
2024-11-18 10:48:46 +05:30
ashilkn
9de634ab8b
[mob][photos] Use an app bar that occupies less space on UI in 'all' section of people section compared to the app bar used in 'all' screen of other sections
2024-11-18 10:31:05 +05:30
ashilkn
58887ce044
[mob][photos] Make 'all' screen of people section more similar to 'all' screen of other sections
2024-11-18 10:25:07 +05:30
ashilkn
8ba65c599a
[mob][photos] Fix SafeArea widget breaking the item size logic on 'all' screen of people section
2024-11-18 10:00:01 +05:30
laurenspriem
12fc4816c7
[mob][photos] More refactor
2024-11-16 19:00:50 +05:30
laurenspriem
826383ccdf
[mob][photos] Refactor face thumbnail generation
2024-11-16 18:43:24 +05:30
ashilkn
392ec34f25
[mob][photos] Remove hero animation from People section because when it's enabled, there is a UI glitch because of an issue in flutter
...
https://github.com/flutter/flutter/issues/47991
2024-11-15 20:57:15 +05:30
Prateek Sunal
e0ffde3f25
[mob][image-editor] dismiss page on save edits ( #4036 )
...
## Description
Previously saving edits would not close the page, this PR fixes that.
## Tests
2024-11-15 19:48:55 +05:30
Simon Dubrulle
a88586c437
Added (draft) doc for mobile translations + added 2 new source strings for "add_participant_page"
2024-11-15 13:40:29 +01:00
ashilkn
102929a5d6
[mob][photos] Decrease the chances of hero animation not working between faces in 'All' screen of People and People section when going back to search section from 'All' screen
2024-11-15 17:43:32 +05:30
laurenspriem
d4479a1a66
[mob][photos] Extract to string
2024-11-15 15:49:58 +05:30
laurenspriem
0f3e490699
[mob][photos] Don't keep showing the banner
2024-11-15 15:45:23 +05:30
laurenspriem
8a7e11e4af
[mob][photos] Enable ml banner
2024-11-15 15:37:35 +05:30
ashilkn
27d5ef2bc0
[mob][photos] Fix alignment of faces in People section
2024-11-15 15:31:53 +05:30
laurenspriem
8d2288fbb4
[mob][photos] super key
2024-11-15 15:22:27 +05:30
Neeraj Gupta
179e586671
[mob] Refactor
2024-11-15 15:18:29 +05:30
Neeraj Gupta
92f6d027db
[mob] Clean up
2024-11-15 15:13:23 +05:30
ashilkn
39252122ef
[mob][photos] Show all faces in 'All' section of faces
2024-11-15 13:35:41 +05:30
ashilkn
184323429a
[mob][photos] Create new 'All' page for people section
2024-11-15 13:22:29 +05:30
Prateek Sunal
120053f61d
fix: dismiss image editor on save edits
2024-11-15 02:24:13 +05:30
Prateek Sunal
01b7a01dc5
Merge remote-tracking branch 'origin/main' into mobile-preview-video
2024-11-15 02:02:51 +05:30
ashilkn
e9923fbf44
[mob][photos] Change UI of PersonSearchExample widget
2024-11-14 17:07:38 +05:30
Neeraj Gupta
3f6f031cfe
Merge branch 'main' into save_contact
2024-11-14 11:55:50 +05:30
laurenspriem
f1ca5ccbd0
[mob][photos] Copy change for model download
2024-11-13 16:38:17 +05:30
laurenspriem
822aa7fcd4
[mob][photos] Make sure user can add back rejected faces
2024-11-13 14:38:51 +05:30
Prateek Sunal
bbfa447e42
fix: source preview file as videoplayer's input
2024-11-11 23:55:33 +05:30
Prateek Sunal
c83bd41dae
Merge remote-tracking branch 'origin/main' into mobile-preview-video
2024-11-11 22:01:30 +05:30
Ashil
d25b1f7b65
[mob][photos] Concatenate strings more efficiently ( #3985 )
...
## Description
If number of iterations are high, concatenating a list of values to a
string using `str1 += str2` can block the UI thread.
Using `List.join()` is a much more efficient way to do this.
2024-11-09 09:34:49 +05:30
Neeraj Gupta
d769cfad55
[mob] Refactor
2024-11-09 08:27:52 +05:30
ashilkn
1e9188f510
[mob][photos] Replace string concatenation happening in loop using '+' with more efficient alternative of by using 'List.join(). If number of iterations are very large, using '+' for concatenation can block the UI thread'
2024-11-08 21:38:33 +05:30
ashilkn
10f9638f24
[mob][photos] Chore
2024-11-08 18:30:29 +05:30
ashilkn
8965f1cd09
[mob][photos] Fix: Cast not working on android (Pair with PIN option)
2024-11-08 18:27:35 +05:30
ashilkn
65131a15ef
[mob][photos] Fix
2024-11-07 23:59:18 +05:30
ashilkn
25b26ec303
[mob][photos] Workaround for a UX issue
2024-11-07 23:31:48 +05:30
