ashilkn
88440400c2
[mob][photos] Fix loading state not appearing when the first filter is added in hierarchical search
2024-11-07 23:29:24 +05:30
ashilkn
88f613187d
Revert "[mob] Render people section in GridView ( #3958 )"
...
This reverts commit 7a99c8be63f1e7c0bec9ec8fa69158acd3147cc7, reversing
changes made to 287d4b00e1f8b11b214dfc22633847d997ebc77f.
2024-11-07 23:15:17 +05:30
ashilkn
219ff7d2e9
Revert "[mob][photos] Add option to make 'only them' filter work a little different only for testing, for feedback on which option is better"
...
This reverts commit ebae813ee37fde8132ea5e11312862176adf0cc2.
2024-11-07 22:34:09 +05:30
ashilkn
65e8ff4da8
[mob][photos] Resolve merge conflicts and merge main
2024-11-07 22:21:44 +05:30
ashilkn
9becee9a85
[mob][photos] Remove unnecessary clipping
2024-11-07 22:09:03 +05:30
ashilkn
52663ae218
[mob][photos] Add comment
2024-11-07 22:00:34 +05:30
ashilkn
c5aecaf501
[mob][photos] Remove unused method
2024-11-07 21:54:11 +05:30
ashilkn
655d9602e0
[mob][photos] Dispose all notifiers of SearchFilterDataProvider after use
2024-11-07 21:47:58 +05:30
ashilkn
b83b7ad295
[mob][photos] Use better names
2024-11-07 20:23:34 +05:30
ashilkn
ae3b784463
[mob][photos] Improvements on PeopleBanner shown in hierarchical search
2024-11-07 19:59:14 +05:30
ashilkn
93fd05818a
[mob][photos] Show 'Add a name' banner if an unnamed cluster is applied in hierarchical search
...
If there are multiple applied unnamed clusters, the banner will be shown for the first one
2024-11-07 18:35:21 +05:30
ashilkn
68fa429611
[mob][photos] Make PeopleBanner UI better and minimal
2024-11-07 18:07:00 +05:30
Neeraj Gupta
3a09d50972
Merge branch 'main' into mobile-preview-video
2024-11-07 17:52:08 +05:30
ashilkn
4b2a845fd0
[mob][photos] Give a more subtle shadow for PeopleBanner
2024-11-07 17:35:11 +05:30
ashilkn
f2e99d5efd
[mob][photos] Keep the galleryType as GalleryType.peopleTag when an 'Only them' filter is applied when, the initial filter is a face filter so that the selection option are of the inital face filter's
...
Needed to write extra code to make it work for 'Only them' face since the current logic checks if inital filter is in applied list, and if yes keep the gallery type unchanged and if not, change gallery type to GalleryType.searchResults. Since an 'Only them' filter is not exactly the same as a Face filter, had to write more code to handle this case since the 'Only them' filter can have the inital Face filter in it
2024-11-06 22:03:40 +05:30
ashilkn
d355d4c1f0
[mob][photos] Fix null check operator used on null value exception right after adding name to a person
2024-11-06 21:39:14 +05:30
ashilkn
042cbdeee7
[mob][photos] Refactor
2024-11-06 21:16:24 +05:30
ashilkn
ca3c7ae526
[mob][photos] UI tweaks on pricing page
2024-11-06 19:13:44 +05:30
ashilkn
64b113bd21
[mob][photos] Refactor
2024-11-06 15:21:45 +05:30
Neeraj Gupta
6e86c7dff0
[mob] Show people in grid view
2024-11-06 14:25:42 +05:30
Neeraj Gupta
0e27e1c928
[mob] Lint suggestion
2024-11-06 13:38:23 +05:30
Neeraj Gupta
fad4077f76
[mob] Separate all page for people
2024-11-06 13:37:50 +05:30
Neeraj Gupta
6a878b165d
[mob] Lint
2024-11-06 12:38:36 +05:30
ashilkn
bdc80c8f97
Merge branch 'main' into hierarchical_search
2024-11-05 22:31:42 +05:30
ashilkn
ebae813ee3
[mob][photos] Add option to make 'only them' filter work a little different only for testing, for feedback on which option is better
2024-11-05 22:27:38 +05:30
ashilkn
724b9620be
[mob][photos] chore
2024-11-05 19:45:29 +05:30
ashilkn
30cde90a68
[mob][photos] Only add initialGalleryFilter to filters to avoid in recommendations list when there are no applied filters
...
This resolves a bug: If 'A' is the initialGalleryFilter and a filter 'B' is applied (in this state both A and B filters are applied), and then the filter 'A' is removed, in recommendations, filter 'A' is not recommended since it's passed as a filter to avoid in recommendations
2024-11-05 16:18:49 +05:30
Neeraj Gupta
fb4c1b206d
[mob] Basic skeleton to save person
2024-11-05 11:47:23 +05:30
ashilkn
b036079249
[mob][photos] Do not show any face filters in recommendations when an 'Only them' filter is applied
2024-11-04 17:49:20 +05:30
Laurens Priem
59f7b316c3
Copy ( #3930 )
...
Copy change
2024-11-04 16:04:17 +05:30
Neeraj Gupta
a4de4fe4b7
[mob] Fix nav bug during person label assignment
2024-11-04 15:54:59 +05:30
ashilkn
b2c6374010
[mob][photos] Stop showing name of face filter so that it occupies less space in UI
2024-10-30 21:24:20 +05:30
ashilkn
e0e6980dac
[mob][photos] Use thumbnail image for face filter thumbnails
2024-10-30 21:09:33 +05:30
ashilkn
556fb50870
[mob][photos] Move different filter chip widgets to separate files
2024-10-30 15:56:18 +05:30
ashilkn
da38c3e9f5
[mob][photos] Fix missing files in hierarchical search when searching over an archived album
2024-10-30 15:40:33 +05:30
ashilkn
e6813aa042
[mob][photos] When an 'only them' filter is added, remove all individual face filters from applied list
2024-10-29 20:20:31 +05:30
ashilkn
4717e48598
[mob][photos] Show thumbnail for 'only them' filter with different layouts depending on the number of faces in filter
2024-10-29 18:52:52 +05:30
laurenspriem
1277c9d188
[mob][photos] Copy
2024-10-29 18:16:16 +05:30
ashilkn
f753779860
[mob][photos] Create only them filter and add it to recommendations on a condition
2024-10-29 17:26:18 +05:30
Aman Raj Singh Mourya
c849ea1046
[mob][photos] use better dialog widget to ask permissions
2024-10-26 17:12:52 +05:30
Aman Raj Singh Mourya
b3f332cbb5
[mob][photos] open owned collection without fetching from the server
2024-10-26 13:14:45 +05:30
Neeraj Gupta
27dd13324e
ML Lite ( #3838 )
...
## Description
- Adds an option to not index files locally on mobile
- Uses the global ML flag for consent
## Tests
Tested in debug mode on my Pixel 8.
2024-10-25 11:18:36 +05:30
laurenspriem
0a2090e2fb
[mob][photos] Rename keys
2024-10-25 11:15:19 +05:30
laurenspriem
f81c7f6faa
[mob][photos] Refactor
2024-10-25 10:23:35 +05:30
ashilkn
1c3bdb6d69
Merge branch 'main' into hierarchical_search
2024-10-25 09:58:37 +05:30
ashilkn
8b647ed0b1
[mob][photos] Wrap safearea around FilterOptionsBottomSheet
2024-10-25 09:57:39 +05:30
ashilkn
a29f9db35d
[mob][photos] Show loading state in gallery from when a filter is applied to when all computation related to it finishes
2024-10-25 09:10:51 +05:30
ashilkn
ae5ae0c770
[mob][photos] Enable hierarchical search for uncategorized album
2024-10-25 08:34:55 +05:30
ashilkn
567ae6aa41
Revert "[mob][photos] Change leading width of appbar when filters are applied"
...
This reverts commit 925abee3c52f1a8874f4f1b84d5a8946222f7e28.
2024-10-25 08:23:38 +05:30
ashilkn
925abee3c5
[mob][photos] Change leading width of appbar when filters are applied
2024-10-24 21:10:52 +05:30
