kenmirrors/ente
1
0
Fork 0
mirror of https://github.com/ente-io/ente.git synced 2025-08-07 15:09:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

[server] Remove slow req logging

Browse Source
This commit is contained in:
Neeraj Gupta 2024-08-26 17:10:07 +05:30 committed by Neeraj Gupta
parent 3dd9be921a
commit b258c3a6b7
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
server/pkg/controller/filedata/controller.go
View File

@ -17,7 +17,6 @@ import (
"github.com/ente-io/museum/pkg/utils/network" "github.com/ente-io/museum/pkg/utils/network"
"github.com/ente-io/museum/pkg/utils/s3config" "github.com/ente-io/museum/pkg/utils/s3config"
"github.com/ente-io/stacktrace" "github.com/ente-io/stacktrace"
"github.com/gin-contrib/requestid"
"github.com/gin-gonic/gin" "github.com/gin-gonic/gin"
log "github.com/sirupsen/logrus" log "github.com/sirupsen/logrus"
"strings" "strings"
@ -77,9 +76,6 @@ func New(repo *fileDataRepo.Repository,
} }
func (c *Controller) InsertOrUpdate(ctx *gin.Context, req *fileData.PutFileDataRequest) error { func (c *Controller) InsertOrUpdate(ctx *gin.Context, req *fileData.PutFileDataRequest) error {
startTime := gTime.Now()
opStartTime := gTime.Now()
logFields := log.Fields{}
if err := req.Validate(); err != nil { if err := req.Validate(); err != nil {
return stacktrace.Propagate(err, "validation failed") return stacktrace.Propagate(err, "validation failed")
} }
@ -88,8 +84,6 @@ func (c *Controller) InsertOrUpdate(ctx *gin.Context, req *fileData.PutFileDataR
if err != nil { if err != nil {
return stacktrace.Propagate(err, "") return stacktrace.Propagate(err, "")
} }
logFields["validationTime"] = gTime.Since(opStartTime).Milliseconds()
opStartTime = gTime.Now()
if req.Type != ente.MlData && req.Type != ente.PreviewVideo { if req.Type != ente.MlData && req.Type != ente.PreviewVideo {
return stacktrace.Propagate(ente.NewBadRequestWithMessage("unsupported object type "+string(req.Type)), "") return stacktrace.Propagate(ente.NewBadRequestWithMessage("unsupported object type "+string(req.Type)), "")
} }
@ -118,8 +112,6 @@ func (c *Controller) InsertOrUpdate(ctx *gin.Context, req *fileData.PutFileDataR
log.Error(uploadErr) log.Error(uploadErr)
return stacktrace.Propagate(uploadErr, "") return stacktrace.Propagate(uploadErr, "")
} }
logFields["uploadTime"] = gTime.Since(opStartTime).Milliseconds()
opStartTime = gTime.Now()
row := fileData.Row{ row := fileData.Row{
FileID: req.FileID, FileID: req.FileID,
@ -132,14 +124,6 @@ func (c *Controller) InsertOrUpdate(ctx *gin.Context, req *fileData.PutFileDataR
if err != nil { if err != nil {
return stacktrace.Propagate(err, "") return stacktrace.Propagate(err, "")
} }
logFields["dbInsertTime"] = gTime.Since(opStartTime).Milliseconds()
// log if total time is more than 2 seconds
if gTime.Since(startTime) > 2*gTime.Second {
logFields["totalTime"] = gTime.Since(startTime).Milliseconds()
logFields["req_id"] = requestid.Get(ctx)
logFields["fileID"] = req.FileID
log.WithFields(logFields).Warn("slow request")
}
return nil return nil
} }