From b258c3a6b72b7b07f03e5730fb8a86aa981f4992 Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Mon, 26 Aug 2024 17:10:07 +0530 Subject: [PATCH] [server] Remove slow req logging --- server/pkg/controller/filedata/controller.go | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/server/pkg/controller/filedata/controller.go b/server/pkg/controller/filedata/controller.go index 98b08e47d6..2be4ebb04c 100644 --- a/server/pkg/controller/filedata/controller.go +++ b/server/pkg/controller/filedata/controller.go @@ -17,7 +17,6 @@ import ( "github.com/ente-io/museum/pkg/utils/network" "github.com/ente-io/museum/pkg/utils/s3config" "github.com/ente-io/stacktrace" - "github.com/gin-contrib/requestid" "github.com/gin-gonic/gin" log "github.com/sirupsen/logrus" "strings" @@ -77,9 +76,6 @@ func New(repo *fileDataRepo.Repository, } func (c *Controller) InsertOrUpdate(ctx *gin.Context, req *fileData.PutFileDataRequest) error { - startTime := gTime.Now() - opStartTime := gTime.Now() - logFields := log.Fields{} if err := req.Validate(); err != nil { return stacktrace.Propagate(err, "validation failed") } @@ -88,8 +84,6 @@ func (c *Controller) InsertOrUpdate(ctx *gin.Context, req *fileData.PutFileDataR if err != nil { return stacktrace.Propagate(err, "") } - logFields["validationTime"] = gTime.Since(opStartTime).Milliseconds() - opStartTime = gTime.Now() if req.Type != ente.MlData && req.Type != ente.PreviewVideo { return stacktrace.Propagate(ente.NewBadRequestWithMessage("unsupported object type "+string(req.Type)), "") } @@ -118,8 +112,6 @@ func (c *Controller) InsertOrUpdate(ctx *gin.Context, req *fileData.PutFileDataR log.Error(uploadErr) return stacktrace.Propagate(uploadErr, "") } - logFields["uploadTime"] = gTime.Since(opStartTime).Milliseconds() - opStartTime = gTime.Now() row := fileData.Row{ FileID: req.FileID, @@ -132,14 +124,6 @@ func (c *Controller) InsertOrUpdate(ctx *gin.Context, req *fileData.PutFileDataR if err != nil { return stacktrace.Propagate(err, "") } - logFields["dbInsertTime"] = gTime.Since(opStartTime).Milliseconds() - // log if total time is more than 2 seconds - if gTime.Since(startTime) > 2*gTime.Second { - logFields["totalTime"] = gTime.Since(startTime).Milliseconds() - logFields["req_id"] = requestid.Get(ctx) - logFields["fileID"] = req.FileID - log.WithFields(logFields).Warn("slow request") - } return nil }