Commit Graph

31940 Commits

Author SHA1 Message Date
sungtae kim
30d568ddec stasis.c: Added topic_all container
Added topic_all container for centralizing the topic. This makes more
easier to managing the topics.

Added cli commands.
stasis show topics : It shows all registered topics.
stasis show topic <name> : It shows speicifed topic's detail info.

ASTERISK-28264

Change-Id: Ie86d125d2966f93de74ee00f47ae6fbc8c081c5f
2019-03-28 00:57:16 +01:00
Joshua Colp
4a9e30e286 Merge "vector: Add AST_VECTOR_COMPACT() to reclaim wasted space" 2019-03-18 06:31:46 -05:00
Joshua Colp
a284587460 Merge "Revert "Test_cel: Fails when DONT_OPTIMIZE is off"" 2019-03-18 06:05:31 -05:00
Joshua Colp
3bd7725ce1 Merge "Variable ALTCONF ignored when service is used in Debian" 2019-03-18 06:00:06 -05:00
George Joseph
12c6a12521 Merge "app.c: Remove deletion of pool topic on mwi state delete" 2019-03-15 18:30:08 -05:00
Sean Bright
0fac5bcbe5 vector: Add AST_VECTOR_COMPACT() to reclaim wasted space
This might be useful in situations where you are loading an undetermined number
of items into a vector and don't want to keep (potentially) 2x the necessary
memory around indefinitely.

Change-Id: I9711daa0fe01783fc6f04c5710eba84f2676d7b9
2019-03-15 14:53:39 -06:00
Richard Mudgett
45a8892e67 taskprocessor.c: Fix printf type mismatch
A size_t is not always an unsigned long.

* Use the %zu format specifier in the ast_cli() printf format string since
AST_VECTOR_SIZE() returns a size_t value.

Change-Id: Ib102dd36bbe6c2a7a4ce6870ae9110d978dd7e98
2019-03-14 12:46:35 -06:00
George Joseph
63d90c38eb app.c: Remove deletion of pool topic on mwi state delete
As part of an earlier voicemail refactor, ast_delete_mwi_state_full
was modified to remove the pool topic for a mailbox when the state
was deleted.  This was an attempt to prevent stale topics from
accumulating when app_voicemail was reloaded and a mailbox went
away.  Unfortunately because of the fact that when app_voicemail
reloads, ALL mailboxes are deleted then only current ones recreated,
topics were being removed from the pool that still had subscribers
on them, then recreated as new topics of the same name.  So now
modules like res_pjsip_mwi are listening on a topic that will
never receive any messages because app_voicemail is publishing on
a different topic that happens to have the same name.  The solutiuon
to this is not easy and given that accumulating topics for
deleted mailboxes is less evil that not sending NOTIFYs...

* Removed the call to stasis_topic_pool_delete_topic in
  ast_delete_mwi_state_full.

Also:

* Fixed a topic reference leak in res_pjsip_mwi
  mwi_stasis_subscription_alloc.

* Added some debugging to mwi_stasis_subscription_alloc,
  stasis_topic_create, and topic_dtor.

* Fixed a topic reference leak in an error path in
  internal_stasis_subscribe.

ASTERISK-28306
Reported-by: Jared Hull

Change-Id: Id7da0990b3ac4be4b58491536b35f41291247b27
2019-03-14 08:31:32 -06:00
Joshua C. Colp
a145f83d30 Merge "stasis: Improve topic/subscription names and statistics." 2019-03-14 09:22:14 -05:00
Joshua C. Colp
783122ec87 Merge "res_musiconhold: Remove redundant option parsing" 2019-03-14 09:19:55 -05:00
Joshua C. Colp
b0db18432e Merge "stasis: Allow empty application arguments to move." 2019-03-13 11:46:13 -05:00
cirillor
7d5409912f Variable ALTCONF ignored when service is used in Debian
When variable ALTCONF is defined, the command start prints the message
"Unable to open specified master config file '"/etc/asterisk/asteris..."
and use default configurations.

ASTERISK-28332

Change-Id: I7595e582a0ee2c1051ea35435e247e27906957ef
2019-03-13 10:37:11 -06:00
Kevin Harwell
41dc6e57f6 Merge "app_queue: fix ring_entry to access nativeformats with a channel lock" 2019-03-13 11:17:48 -05:00
Kevin Harwell
8f5a6ed52d Merge "chan_dahdi: Add logical group at DAHDIChannel event and CHANNEL function" 2019-03-13 10:55:20 -05:00
Joshua Colp
1d074debfb stasis: Allow empty application arguments to move.
Change-Id: I1e4d37415f3034abe36496dc30209c2303e6af5c
2019-03-13 07:55:57 -06:00
Corey Farrell
a40198a4d4 Revert "Test_cel: Fails when DONT_OPTIMIZE is off"
This reverts commit 1c8378bbc9.

Change-Id: I1b9227b263c3dc4246a50aebf52a7640a0f7ea07
2019-03-13 09:30:40 -04:00
Joshua C. Colp
cb37486215 Merge "partial-inlining: disable partial-inlining if gcc>=8.2.1" 2019-03-13 07:24:47 -05:00
Dömsödi Gergely
48e407e506 app_queue: fix ring_entry to access nativeformats with a channel lock
Fixes an intermittent segmentation fault which occured when accessing
nativeformats of a channel which entered into a queue.

ASTERISK-27964
Reported by: Francisco Seratti

Change-Id: Ic87fa7a363f3b487c24ce07032f4b2201c22db9e
2019-03-13 04:49:21 -06:00
George Joseph
6f158d27fc Makefile.moddir_rules: Pass PJPROJECT_BUNDLED to download_externals
The download_externals script wasn't getting the PJPROJECT_BUNDLED
environment variable passed down to it so it wasn't downloading
the appropriate variant of res_digium_phone.  This could cause
crashes in the DPMA.

Change-Id: I5daa9369c7af1fd556d892e89a85f279a2533425
2019-03-12 12:28:08 -06:00
Friendly Automation
4114c2bc3c Merge "chan_pjsip: add a flag to ignore 183 responses if no SDP present" 2019-03-12 10:10:12 -05:00
Chris-Savinovich
449dff997c partial-inlining: disable partial-inlining if gcc>=8.2.1
Apply flag -fno-partial-inlining on default optimization if and only if
gcc version >= 8.2.1 (this is the current ver on Fedora and Ubuntu).
This is done to avoid a bug that causes arithmetic calculations to fail
if the following conditions are met:
1. TEST_FRAMEWORK on
2. DONT_OPTIMIZE off
3. Fedora and Ubuntu
4. GCC 8.2.1
5. There must exist a certain combination of multithreading.
6. Optimization level -O2 and -O3
7. Flag -fpartial-inline activated (default when optimization level>=2)
The following link points to a similar gcc bug reported in 2015. This leads me
to believe the bug has regressed. Note I am not able to replicate this bug
in an environment other than Asterisk + Test Framework + Test_cel because the
multithreading combination that causes it seems to be unique. Therefore I
am temporarily abandoning any thoughts of reporting the new occurrence of this
bug to gcc.gnu.org.  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65307

Change-Id: Ibd1afe60e0a38b88e85fdcd9b051004601c2f102
2019-03-11 11:20:53 -06:00
George Joseph
30c19527bf Merge "app_meetme: Don't mute joining admins if conference is muted" 2019-03-11 09:49:03 -05:00
Friendly Automation
d93c931503 Merge "res/res_rtp_asterisk.c: Fixing possible divide by zero" 2019-03-11 09:45:28 -05:00
Joshua Colp
0231dd6ae7 stasis: Improve topic/subscription names and statistics.
Topic names now follow: <subsystem>:<functionality>[/<object>]

This ensures that they are all unique, and also provides better
insight in to what each topic is for.

Subscriber ids now also use the main topic name they are
subscribed to and an incrementing integer as their identifier to
make it easier to understand what the subscription is primarily
responsible for.

Both the CLI commands for listing topic and subscription statistics
now sort to make it a bit easier to see what is going on.

Subscriptions will now show all topics that they are receiving messages
from, not just the main topic they were subscribed to.

ASTERISK-28335

Change-Id: I484e971a38c3640f2bd156282e532eed84bf220d
2019-03-11 11:39:35 -03:00
cirillor
0d6d51b175 chan_dahdi: Add logical group at DAHDIChannel event and CHANNEL function
Add logical group at DAHDIChannel event
and create "dahdi_group" at CHANNEL function.

ASTERISK-28317

Change-Id: Ic1f834cd53982a9707a9748395ee746d6575086a
2019-03-11 06:32:24 -06:00
sungtae kim
8641fd9700 res/res_rtp_asterisk.c: Fixing possible divide by zero
Currently, when the Asterisk calculates rtp statistics, it uses
sample_count as a unsigned integer parameter. This would be fine
for most of cases, but in case of large enough number of sample_count,
this might be causing the divide by zero error.

ASTERISK-28321

Change-Id: If7e0629abaceddd2166eb012456c53033ea26249
2019-03-11 09:09:09 -03:00
Sean Bright
825ea9ddb9 res_musiconhold: Remove redundant option parsing
Change-Id: I481fabd8eaf2e4e7ffb5c8285b294742826e7d12
2019-03-08 14:17:01 -06:00
Torrey Searle
4661c08549 chan_pjsip: add a flag to ignore 183 responses if no SDP present
chan_sip will always ignore 183 responses that do not contain SDP
however, chan_pjsip will currently always translate it into a
183 with SDP.  This new flag allows chan_pjsip to have the same
behavior as chan_sip.

ASTERISK-28322 #close

Change-Id: If81cfaa17c11b6ac703e3d71696f259d86c6be4a
2019-03-08 14:16:30 -05:00
Corey Farrell
9b7b8cb155 jansson: json_pack with new format to verify required runtime version.
Add a json_pack at startup that will fail if runtime links against a
library older than jansson-2.11.

Change-Id: I101aebafe0f9407650206f7c552dad3d69377b5a
2019-03-08 12:47:50 -06:00
George Joseph
5f6890a8f9 Merge "res_stasis: Add ability to switch applications." 2019-03-08 12:43:45 -06:00
George Joseph
9390333862 Merge "Replace calls to strtok() with strtok_r()" 2019-03-08 12:42:44 -06:00
Friendly Automation
a502cb81db Merge "samples: Fix comment typo in pjsip.conf.sample" 2019-03-08 12:11:42 -06:00
George Joseph
228205f520 Merge "bridging: Add creation timestamps" 2019-03-08 11:11:36 -06:00
Sean Bright
57850c7861 app_meetme: Don't mute joining admins if conference is muted
ASTERISK-28328 #close

Change-Id: I4f6069fb34923b7521520c2a205a1e56227e592b
2019-03-08 10:44:00 -06:00
Sean Bright
2473b791b9 Replace calls to strtok() with strtok_r()
strtok() uses a static buffer, making it not thread safe.

Also add a #define to cause a compile failure if strtok is used.

Change-Id: Icce265153e1e65adafa8849334438ab6d190e541
2019-03-07 16:44:50 -06:00
Sean Bright
7b02a9617c samples: Fix comment typo in pjsip.conf.sample
Change-Id: I84a45c3d9fd26ca61aca99927eec83b57f1de857
2019-03-07 16:06:38 -06:00
Ben Ford
6626df586e res_stasis: Add ability to switch applications.
Added the ability to move between Stasis applications within Stasis.
This can be done by calling 'move' in an application, providing (at
minimum) the channel's id and the application to switch to. If the
application is not registered or active, nothing will happen and the
channel will remain in the current application, and an event will be
triggered to let the application know that the move failed. The event
name is "ApplicationMoveFailed", and provides the "destination" that the
channel was attempting to move to, as well as the usual channel
information. Optionally, a list of arguments can be passed to the
function call for the receiving application. A full example of a 'move'
call would look like this:

client.channels.move(channelId, app, appArgs)

The control object used to control the channel in Stasis can now switch
which application it belongs to, rather than belonging to one Stasis
application for its lifetime. This allows us to use the same control
object instead of having to tear down the current one and create
another.

ASTERISK-28267 #close

Change-Id: I43d12b10045a98a8d42541889b85695be26f288a
2019-03-07 07:53:01 -06:00
Friendly Automation
a32f525489 Merge "sip_to_pjsip: Make multiline comment parsing consistent with Asterisk" 2019-03-05 09:17:38 -06:00
Friendly Automation
5e21763560 Merge "app_queue: Handle empty 'interface' in queue member config" 2019-03-05 08:50:57 -06:00
Joshua Colp
c20b84e35b Merge "res_pjsip_registrar: blocked threads on reliable transport shutdown take 3" 2019-03-05 07:16:05 -06:00
Joshua Colp
d7eed3bc5d Merge "basic-pbx: Update configuration to work with current modules." 2019-03-05 07:04:50 -06:00
Sean Bright
f6b5b7208c app_queue: Handle empty 'interface' in queue member config
While the 'interface' column is a NOT NULL, the empty string is still
allowed. res_config_odbc treats the empty string as a NULL and we crash
when trying to dereference.

Also cleaned up an adjacent error message for consistency.

ASTERISK-28168 #close

Change-Id: I55e012b540fbcda99bb40bede3099b7ae5db8202
2019-03-04 16:07:46 -06:00
Sean Bright
f098d4a325 sip_to_pjsip: Make multiline comment parsing consistent with Asterisk
In Asterisk configuration, a multiline comment starts with ;-- as long as it is
not followed by another dash (i.e. ;--- is not a multiline comment).

ASTERISK-28323 #close

Change-Id: I32dc38e0fac01d3c0805d27d35d2365a7c37ca72
2019-03-04 13:40:43 -06:00
Friendly Automation
d490db8d58 Merge "res_pjsip_diversion: Use static pj_str_t for Diversion header names" 2019-03-04 06:13:48 -06:00
Joshua Colp
20e7ae1556 Merge "CHANGES: Document addition of 'wrapuptime' argument to AddQueueMember()" 2019-03-04 05:50:47 -06:00
Joshua Colp
2980622d2b basic-pbx: Update configuration to work with current modules.
The res_pjsip_websocket module requires the res_http_websocket
module so ensure it is loaded. As well the res_pjsip_notify
module needs the pjsip_notify.conf configuration file so
ensure it is installed.

ASTERISK-28272

Change-Id: I261659b84e7a6ac4cb49990d9badb4b2ad01bacd
2019-03-04 05:03:05 -06:00
sungtae kim
3638c433ac bridging: Add creation timestamps
This small feature will help to checking the bridge's status to
figure out which bridge is in old/zombie or not. Also added
detail items for the 'bridge show *' cli to provide more detail
info. And added creation item to the ARI as well.

ASTERISK-28279

Change-Id: I460238c488eca4d216b9176576211cb03286e040
2019-03-03 05:25:22 -06:00
Sean Bright
106a8ff05c res_pjsip_diversion: Use static pj_str_t for Diversion header names
PJSIP assumes that these header names are not allocated, and does not
clone the name strings when reusing headers.

Block unload of res_pjsip_diversion until shutdown to ensure static
memory stays valid.

ASTERISK-28312 #close

Change-Id: Ibd6ea55ec4a604bbd43ac07f8d0b54da2c39b8b9
2019-03-01 16:47:22 -06:00
Kevin Harwell
67d5c469fb Merge "res_config_odbc: Avoid deadlock when max_connections = 1" 2019-03-01 16:20:45 -06:00
Rodrigo Ramírez Norambuena
f8295e0771 CHANGES: Document addition of 'wrapuptime' argument to AddQueueMember()
Change-Id: Ieb332d018ae3f2fc82b9465381fde0f299af1611
2019-03-01 16:18:01 -06:00