kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-04 20:04:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

app_queue: Handle empty 'interface' in queue member config

Browse Source 
While the 'interface' column is a NOT NULL, the empty string is still
allowed. res_config_odbc treats the empty string as a NULL and we crash
when trying to dereference.

Also cleaned up an adjacent error message for consistency.

ASTERISK-28168 #close

Change-Id: I55e012b540fbcda99bb40bede3099b7ae5db8202
This commit is contained in:
Sean Bright
2019-03-04 17:05:30 -05:00
parent 90f0f6659d
commit 88681ba9bb
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/app_queue.c
View File

@@ -3410,7 +3410,14 @@ static void rt_handle_member_record(struct call_queue *q, char *category, struct
const char *wrapuptime_str = ast_variable_retrieve(member_config, category, "wrapuptime");
if (ast_strlen_zero(rt_uniqueid)) {
ast_log(LOG_WARNING, "Realtime field uniqueid is empty for member %s\n", S_OR(membername, "NULL"));
ast_log(LOG_WARNING, "Realtime field 'uniqueid' is empty for member %s\n",
S_OR(membername, "NULL"));
return;
}
if (ast_strlen_zero(interface)) {
ast_log(LOG_WARNING, "Realtime field 'interface' is empty for member %s\n",
S_OR(membername, "NULL"));
return;
}