kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-02 19:16:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

bridge_basic.c: Make sure that ast_bridge_channel is not destroyed while iterating over bridge->channels.

Browse Source 
From the gdb information, we can see that while iterating over bridge->channels, the ast_bridge_channel reference count is 0, indicating it has already been destroyed.Additionally, when ast_bridge_channel is removed from bridge->channels, the bridge is first locked. Therefore, locking the bridge before iterating over bridge->channels can resolve the race condition.

Resolves: https://github.com/asterisk/asterisk/issues/768
This commit is contained in:
Tinet-mucw
2024-06-13 19:16:36 -07:00
committed by asterisk-org-access-app[bot]
parent 07aa0ffe6a
commit 7d28165cb1
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
main/bridge_basic.c
View File

@@ -1851,7 +1851,9 @@ static void bridge_ringing(struct ast_bridge *bridge)
.subclass.integer = AST_CONTROL_RINGING,
};
ast_bridge_lock(bridge);
ast_bridge_queue_everyone_else(bridge, NULL, &ringing);
ast_bridge_unlock(bridge);
}
/*!
@@ -1864,7 +1866,9 @@ static void bridge_hold(struct ast_bridge *bridge)
.subclass.integer = AST_CONTROL_HOLD,
};
ast_bridge_lock(bridge);
ast_bridge_queue_everyone_else(bridge, NULL, &hold);
ast_bridge_unlock(bridge);
}
/*!
@@ -1877,7 +1881,9 @@ static void bridge_unhold(struct ast_bridge *bridge)
.subclass.integer = AST_CONTROL_UNHOLD,
};
ast_bridge_lock(bridge);
ast_bridge_queue_everyone_else(bridge, NULL, &unhold);
ast_bridge_unlock(bridge);
}
/*!