kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-04 20:04:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_stun_monitor: Don't fail to load if DNS resolution fails

Browse Source 
res_stun_monitor will fail to load if DNS resolution of the STUN server
fails. Instead, we continue without the STUN server being resolved and
we will re-attempt the resolution on the STUN refresh interval.

ASTERISK-21856 #close
Reported by: Jeremy Kister

Change-Id: I6334c54a1cc798f8a836b4b47948e0bb4ef59254
This commit is contained in:
Sean Bright
2017-04-14 17:50:56 -04:00
parent 5e2a8ef94a
commit 357d1fbdcc
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
res/res_stun_monitor.c
View File

@@ -271,7 +271,7 @@ static int stun_start_monitor(void)
* \retval 0 on success.
* \retval -1 on error.
*/
static int setup_stunaddr(const char *value)
static int setup_stunaddr(const char *value, int reload)
{
char *val;
char *host_str;
@@ -307,8 +307,12 @@ static int setup_stunaddr(const char *value)
stun_addr.ss.ss_family = AF_INET;
if (ast_get_ip(&stun_addr, host_str)) {
ast_log(LOG_WARNING, "Unable to lookup STUN server '%s'\n", host_str);
ast_free(host_str);
return -1;
/* Only treat this as fatal if we are reloading */
if (reload) {
ast_free(host_str);
return -1;
}
}
/* Save STUN server information. */
@@ -350,7 +354,7 @@ static int load_config(int startup)
for (v = ast_variable_browse(cfg, "general"); v; v = v->next) {
if (!strcasecmp(v->name, "stunaddr")) {
if (setup_stunaddr(v->value)) {
if (setup_stunaddr(v->value, !startup)) {
ast_log(LOG_WARNING, "Invalid STUN server address: %s at line %d\n",
v->value, v->lineno);
}