kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-02 19:16:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_stasis_playback: Prevent media_index from going out of bounds

Browse Source 
Incrementing stasis_app_playback.media_index directly in our playback
loop means that when we reach the end of our playlist the index into
the vector will be outside of the bounds of the vector.

Instead use a temporary variable and only assign when we're sure that
we are in bounds.

ASTERISK-28713 #close
Reported by: Sébastien Duthil

Change-Id: Ib53f7f156097e0607eb5871d9d78d246ed274928
This commit is contained in:
Sean Bright
2020-01-28 14:23:19 -05:00
parent 35a782d58a
commit 2a6b09e2e8
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
res/res_stasis_playback.c
View File

@@ -287,6 +287,7 @@ static void play_on_channel(struct stasis_app_playback *playback,
{
int res;
long offsetms;
size_t index;
/* Even though these local variables look fairly pointless, they avoid
* having a bunch of NULL's passed directly into
@@ -305,7 +306,8 @@ static void play_on_channel(struct stasis_app_playback *playback,
offsetms = playback->offsetms;
for (; playback->media_index < AST_VECTOR_SIZE(&playback->medias); playback->media_index++) {
for (index = 0; index < AST_VECTOR_SIZE(&playback->medias); index++) {
playback->media_index = index;
/* Set the current media to play */
ast_string_field_set(playback, media, AST_VECTOR_GET(&playback->medias, playback->media_index));