remove eslint warnings, add npm publish process to Collaboration.md (#3913)

This commit is contained in:
Karsten Hassel
2025-10-14 22:44:37 +02:00
committed by GitHub
parent 5f1f5bd291
commit d39e686f7a
5 changed files with 8 additions and 3 deletions

View File

@@ -20,6 +20,7 @@ planned for 2026-01-01
### Fixed ### Fixed
- feat: add ESlint rule `no-sparse-arrays` for config check to fix #3910 (#3911) - feat: add ESlint rule `no-sparse-arrays` for config check to fix #3910 (#3911)
- fixed eslint warnings shown in #3911 and updated npm publish docs (#3913)
### Updated ### Updated

View File

@@ -66,3 +66,7 @@ Are done by
- [ ] close all issues with label `ready (coming with next release)` - [ ] close all issues with label `ready (coming with next release)`
- [ ] release new documentation by merging `develop` on `master` in documentation repository - [ ] release new documentation by merging `develop` on `master` in documentation repository
- [ ] publish new version on [npm](https://www.npmjs.com/package/magicmirror) - [ ] publish new version on [npm](https://www.npmjs.com/package/magicmirror)
- [ ] use a clean environment (e.g. container)
- [ ] clone this repository with the new `master` branch and `cd` into the local repository directory
- [ ] log in to npm with `npm login --auth-type legacy` which will ask for username and password and one-time-password which is sent via mail
- [ ] execute `npm publish`

View File

@@ -415,7 +415,7 @@ const Module = Class.extend({
}); });
/** /**
* Merging MagicMirror² (or other) default/config script by @bugsounet * Merging MagicMirror² (or other) default/config script by `@bugsounet`
* Merge 2 objects or/with array * Merge 2 objects or/with array
* *
* Usage: * Usage:

View File

@@ -876,7 +876,7 @@ Module.register("calendar", {
* @param {string} url The calendar url * @param {string} url The calendar url
* @param {string} property The property to look for * @param {string} property The property to look for
* @param {string} defaultValue The value if the property is not found * @param {string} defaultValue The value if the property is not found
* @returns {property} The property * @returns {string} The property
*/ */
getCalendarProperty (url, property, defaultValue) { getCalendarProperty (url, property, defaultValue) {
for (const calendar of this.config.calendars) { for (const calendar of this.config.calendars) {

View File

@@ -181,7 +181,7 @@ Module.register("newsfeed", {
* Gets a feed property by name * Gets a feed property by name
* @param {object} feed A feed object. * @param {object} feed A feed object.
* @param {string} property The name of the property. * @param {string} property The name of the property.
* @returns {property} The value of the specified property for the feed. * @returns {string} The value of the specified property for the feed.
*/ */
getFeedProperty (feed, property) { getFeedProperty (feed, property) {
let res = this.config[property]; let res = this.config[property];