From d39e686f7a69fc18f694490b0dd3e32ef0abb5de Mon Sep 17 00:00:00 2001 From: Karsten Hassel Date: Tue, 14 Oct 2025 22:44:37 +0200 Subject: [PATCH] remove eslint warnings, add npm publish process to Collaboration.md (#3913) --- CHANGELOG.md | 1 + Collaboration.md | 4 ++++ js/module.js | 2 +- modules/default/calendar/calendar.js | 2 +- modules/default/newsfeed/newsfeed.js | 2 +- 5 files changed, 8 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 404fdc98..037da15e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,7 @@ planned for 2026-01-01 ### Fixed - feat: add ESlint rule `no-sparse-arrays` for config check to fix #3910 (#3911) +- fixed eslint warnings shown in #3911 and updated npm publish docs (#3913) ### Updated diff --git a/Collaboration.md b/Collaboration.md index befc7943..26397bcc 100644 --- a/Collaboration.md +++ b/Collaboration.md @@ -66,3 +66,7 @@ Are done by - [ ] close all issues with label `ready (coming with next release)` - [ ] release new documentation by merging `develop` on `master` in documentation repository - [ ] publish new version on [npm](https://www.npmjs.com/package/magicmirror) + - [ ] use a clean environment (e.g. container) + - [ ] clone this repository with the new `master` branch and `cd` into the local repository directory + - [ ] log in to npm with `npm login --auth-type legacy` which will ask for username and password and one-time-password which is sent via mail + - [ ] execute `npm publish` diff --git a/js/module.js b/js/module.js index 3a0c6a80..cfc1d1ef 100644 --- a/js/module.js +++ b/js/module.js @@ -415,7 +415,7 @@ const Module = Class.extend({ }); /** - * Merging MagicMirror² (or other) default/config script by @bugsounet + * Merging MagicMirror² (or other) default/config script by `@bugsounet` * Merge 2 objects or/with array * * Usage: diff --git a/modules/default/calendar/calendar.js b/modules/default/calendar/calendar.js index e5b3621f..f7b5cd36 100644 --- a/modules/default/calendar/calendar.js +++ b/modules/default/calendar/calendar.js @@ -876,7 +876,7 @@ Module.register("calendar", { * @param {string} url The calendar url * @param {string} property The property to look for * @param {string} defaultValue The value if the property is not found - * @returns {property} The property + * @returns {string} The property */ getCalendarProperty (url, property, defaultValue) { for (const calendar of this.config.calendars) { diff --git a/modules/default/newsfeed/newsfeed.js b/modules/default/newsfeed/newsfeed.js index 348a0d33..8b3c8901 100644 --- a/modules/default/newsfeed/newsfeed.js +++ b/modules/default/newsfeed/newsfeed.js @@ -181,7 +181,7 @@ Module.register("newsfeed", { * Gets a feed property by name * @param {object} feed A feed object. * @param {string} property The name of the property. - * @returns {property} The value of the specified property for the feed. + * @returns {string} The value of the specified property for the feed. */ getFeedProperty (feed, property) { let res = this.config[property];