Don't lazy load iframes (fixes #2421)

This commit is contained in:
Bernd Bestel 2024-01-10 21:52:54 +01:00
parent 3aeecfa24d
commit efae5fea5b
No known key found for this signature in database
GPG Key ID: 71BD34C0D4891300
7 changed files with 9 additions and 13 deletions

View File

@ -59,6 +59,7 @@
- Optimized sidebar icon spacing (thanks @chris-thorn) - Optimized sidebar icon spacing (thanks @chris-thorn)
- Fixed that file uploads (product pictures and so on) didn't work for files where the file name contains multiple spaces - Fixed that file uploads (product pictures and so on) didn't work for files where the file name contains multiple spaces
- Fixed that some dialogs were not properly (too small) displayed in Firefox >= 121
### API ### API

View File

@ -564,10 +564,6 @@ $(window).on('resize', function()
{ {
ResizeResponsiveEmbeds($("body").hasClass("fullscreen-card")); ResizeResponsiveEmbeds($("body").hasClass("fullscreen-card"));
}); });
$("iframe").on("load", function()
{
ResizeResponsiveEmbeds($("body").hasClass("fullscreen-card"));
});
function WindowMessageBag(message, payload = null) function WindowMessageBag(message, payload = null)
{ {
@ -708,7 +704,7 @@ $(document).on("click", ".show-as-dialog-link", function(e)
var link = $(e.currentTarget).attr("href"); var link = $(e.currentTarget).attr("href");
bootbox.dialog({ bootbox.dialog({
message: '<iframe height="650px" class="embed-responsive" src="' + link + '" loading="lazy"></iframe>', message: '<iframe height="650px" class="embed-responsive" src="' + link + '"></iframe>',
size: 'large', size: 'large',
backdrop: true, backdrop: true,
closeButton: false, closeButton: false,

View File

@ -927,7 +927,7 @@ $(document).on("click", ".display-recipe-button", function(e)
function(result) function(result)
{ {
bootbox.dialog({ bootbox.dialog({
message: '<iframe height="650px" class="embed-responsive" src="' + U("/recipes?embedded&recipe=") + objectId + '#fullscreen" loading="lazy"></iframe>', message: '<iframe height="650px" class="embed-responsive" src="' + U("/recipes?embedded&recipe=") + objectId + '#fullscreen"></iframe>',
size: 'extra-large', size: 'extra-large',
backdrop: true, backdrop: true,
closeButton: false, closeButton: false,

View File

@ -198,7 +198,7 @@ $("#test-quantityunit-plural-forms-button").on("click", function(e)
$("#save-quantityunit-button").click(); $("#save-quantityunit-button").click();
bootbox.alert({ bootbox.alert({
message: '<iframe height="400px" class="embed-responsive" src="' + U("/quantityunitpluraltesting?embedded&qu=") + Grocy.EditObjectId.toString() + '" loading="lazy"></iframe>', message: '<iframe height="400px" class="embed-responsive" src="' + U("/quantityunitpluraltesting?embedded&qu=") + Grocy.EditObjectId.toString() + '"></iframe>',
closeButton: false, closeButton: false,
size: "large", size: "large",
callback: function(result) callback: function(result)

View File

@ -220,7 +220,7 @@ $(document).on('click', '.recipe-pos-edit-button', function(e)
var recipePosId = $(e.currentTarget).attr('data-recipe-pos-id'); var recipePosId = $(e.currentTarget).attr('data-recipe-pos-id');
bootbox.dialog({ bootbox.dialog({
message: '<iframe height="650px" class="embed-responsive" src="' + U("/recipe/") + Grocy.EditObjectId.toString() + '/pos/' + recipePosId.toString() + '?embedded&product=' + productId.toString() + '" loading="lazy"></iframe>', message: '<iframe height="650px" class="embed-responsive" src="' + U("/recipe/") + Grocy.EditObjectId.toString() + '/pos/' + recipePosId.toString() + '?embedded&product=' + productId.toString() + '"></iframe>',
size: 'large', size: 'large',
backdrop: true, backdrop: true,
closeButton: false, closeButton: false,
@ -266,7 +266,7 @@ $("#recipe-pos-add-button").on("click", function(e)
e.preventDefault(); e.preventDefault();
bootbox.dialog({ bootbox.dialog({
message: '<iframe height="650px" class="embed-responsive" src="' + U("/recipe/") + Grocy.EditObjectId + '/pos/new?embedded" loading="lazy"></iframe>', message: '<iframe height="650px" class="embed-responsive" src="' + U("/recipe/") + Grocy.EditObjectId + '/pos/new?embedded"></iframe>',
size: 'large', size: 'large',
backdrop: true, backdrop: true,
closeButton: false, closeButton: false,

View File

@ -291,7 +291,7 @@ recipesTables.on('select', function(e, dt, type, indexes)
else else
{ {
bootbox.dialog({ bootbox.dialog({
message: '<iframe height="650px" class="embed-responsive" src="' + U("/recipes?embedded&recipe=") + selectedRecipeId + '#fullscreen" loading="lazy"></iframe>', message: '<iframe height="650px" class="embed-responsive" src="' + U("/recipes?embedded&recipe=") + selectedRecipeId + '#fullscreen"></iframe>',
size: 'extra-large', size: 'extra-large',
backdrop: true, backdrop: true,
closeButton: false, closeButton: false,
@ -323,7 +323,7 @@ $(".recipe-gallery-item").on("click", function(e)
else else
{ {
bootbox.dialog({ bootbox.dialog({
message: '<iframe height="650px" class="embed-responsive" src="' + U("/recipes?embedded&recipe=") + selectedRecipeId + '#fullscreen" loading="lazy"></iframe>', message: '<iframe height="650px" class="embed-responsive" src="' + U("/recipes?embedded&recipe=") + selectedRecipeId + '#fullscreen"></iframe>',
size: 'extra-large', size: 'extra-large',
backdrop: true, backdrop: true,
closeButton: false, closeButton: false,

View File

@ -322,8 +322,7 @@
<div class="modal-body"> <div class="modal-body">
<iframe id="shopping-list-stock-add-workflow-purchase-form-frame" <iframe id="shopping-list-stock-add-workflow-purchase-form-frame"
class="embed-responsive" class="embed-responsive"
src="" src=""></iframe>
loading="lazy"></iframe>
</div> </div>
<div class="modal-footer"> <div class="modal-footer">
<span id="shopping-list-stock-add-workflow-purchase-item-count" <span id="shopping-list-stock-add-workflow-purchase-item-count"