From d23fda245e7a1974c354213f9a228995f2fd583f Mon Sep 17 00:00:00 2001 From: Bernd Bestel Date: Wed, 31 Mar 2021 22:26:27 +0200 Subject: [PATCH] Fixed that the number picker up/down buttons did not work when the input field was empty or contained an invalid number --- changelog/62_UNRELEASED_xxxx-xx-xx.md | 3 ++- public/viewjs/components/numberpicker.js | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/changelog/62_UNRELEASED_xxxx-xx-xx.md b/changelog/62_UNRELEASED_xxxx-xx-xx.md index e3a4ce1d..3e8ad015 100644 --- a/changelog/62_UNRELEASED_xxxx-xx-xx.md +++ b/changelog/62_UNRELEASED_xxxx-xx-xx.md @@ -21,8 +21,9 @@ ### Userfield fixes - Fixed that numeric Userfields were initialised with `1.0` -### General & other improvements +### General & other improvements/fixes - Some night mode style improvements (thanks @BlizzWave and @KTibow) +- Fixed that the number picker up/down buttons did not work when the input field was empty or contained an invalid number ### API fixes - Fixed that due soon products with `due_type` = "Expiration date" were missing in `due_products` of the `/stock/volatile` endpoint diff --git a/public/viewjs/components/numberpicker.js b/public/viewjs/components/numberpicker.js index 803c71c9..249e2b85 100644 --- a/public/viewjs/components/numberpicker.js +++ b/public/viewjs/components/numberpicker.js @@ -1,7 +1,7 @@ $(".numberpicker-down-button").unbind('click').on("click", function() { var inputElement = $(this).parent().parent().find('input[type="number"]'); - inputElement.val(parseFloat(inputElement.val()) - 1); + inputElement.val(parseFloat(inputElement.val() || 1) - 1); inputElement.trigger('keyup'); inputElement.trigger('change'); }); @@ -9,7 +9,7 @@ $(".numberpicker-down-button").unbind('click').on("click", function() $(".numberpicker-up-button").unbind('click').on("click", function() { var inputElement = $(this).parent().parent().find('input[type="number"]'); - inputElement.val(parseFloat(inputElement.val()) + 1); + inputElement.val(parseFloat(inputElement.val() || 0) + 1); inputElement.trigger('keyup'); inputElement.trigger('change'); });