Improved shopping list item form validation (closes #1226)

views/components/productpicker.blade.php

@@ -11,6 +11,7 @@
 @php if(!isset($disabled)) { $disabled = false; } @endphp
 @php if(empty($hint)) { $hint = ''; } @endphp
 @php if(empty($nextInputSelector)) { $nextInputSelector = ''; } @endphp
+@php if(empty($validationMessage)) { $validationMessage = 'You have to select a product'; } @endphp
 
 <div class="form-group"
 	data-next-input-selector="{{ $nextInputSelector }}"
@@ -57,7 +58,7 @@
 			value="{{ $product->id }}">{{ $product->name }}</option>
 		@endforeach
 	</select>
-	<div class="invalid-feedback">{{ $__t('You have to select a product') }}</div>
+	<div class="invalid-feedback">{{ $__t($validationMessage) }}</div>
 	<div id="custom-productpicker-error"
 		class="form-text text-danger d-none"></div>
 	<div id="flow-info-InplaceAddBarcodeToExistingProduct"

views/shoppinglistitemform.blade.php

@@ -62,8 +62,9 @@
 				@include('components.productpicker', array(
 				'products' => $products,
 				'nextInputSelector' => '#amount',
-				'isRequired' => false,
-				'prefillById' => $productId
+				'isRequired' => true,
+				'prefillById' => $productId,
+				'validationMessage' => 'A product or a note is required'
 				))
 			</div>
 
@@ -79,9 +80,11 @@
 			<div class="form-group">
 				<label for="note">{{ $__t('Note') }}</label>
 				<textarea class="form-control"
+					required
 					rows="10"
 					id="note"
 					name="note">@if($mode == 'edit'){{ $listItem->note }}@endif</textarea>
+				<div class="invalid-feedback">{{ $__t('A product or a note is required') }}</div>
 			</div>
 
 			@include('components.userfieldsform', array(