kenmirrors/grocy
1
0
Fork 0
mirror of https://github.com/grocy/grocy.git synced 2025-08-20 20:26:42 +00:00
Code Issues Projects Releases Wiki Activity

fix: confirm grocycode is of PRODUCT type in GetProductIdFromBarcode (#1581)

Browse Source 
* fix: confirm grocycode is of PRODUCT type in GetProductIdFromBarcode

* Fixed formatting

* Don't output the given input (for security reasons)

Co-authored-by: Bernd Bestel <bernd@berrnd.de>
This commit is contained in:
David Mott
2021-08-15 18:45:05 +10:00
committed by GitHub
parent d23f730a0b
commit 95cb9ffb90
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/StockService.php
View File

@@ -697,6 +697,10 @@ class StockService extends BaseService
if (Grocycode::Validate($barcode)) if (Grocycode::Validate($barcode))
{ {
$gc = new Grocycode($barcode); $gc = new Grocycode($barcode);
if ($gc->GetType() != Grocycode::PRODUCT)
{
throw new \Exception('Invalid grocycode');
}
return intval($gc->GetId()); return intval($gc->GetId());
} }