From 6ad761e067e991254f561d6877dc8fa675b5e9cc Mon Sep 17 00:00:00 2001 From: Bernd Bestel Date: Tue, 19 Apr 2022 16:56:48 +0200 Subject: [PATCH] Optimized LDAP error handling (references #1865) --- middleware/LdapAuthMiddleware.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/middleware/LdapAuthMiddleware.php b/middleware/LdapAuthMiddleware.php index 7f87b2e7..0099492a 100644 --- a/middleware/LdapAuthMiddleware.php +++ b/middleware/LdapAuthMiddleware.php @@ -42,7 +42,16 @@ class LdapAuthMiddleware extends AuthMiddleware $filter = '(&(' . GROCY_LDAP_UID_ATTR . '=' . $postParams['username'] . ')' . GROCY_LDAP_USER_FILTER . ')'; $search = ldap_search($connect, GROCY_LDAP_BASE_DN, $filter); + if ($search === false) + { + throw new \Exception('LDAP error: ' . ldap_error($connect)); + } + $result = ldap_get_entries($connect, $search); + if ($result === false) + { + throw new \Exception('LDAP error: ' . ldap_error($connect)); + } $ldapFirstName = $result[0]['givenname'][0]; $ldapLastName = $result[0]['sn'][0];