From 52e2c6d4801e34f5641855efe63ccd01968ef481 Mon Sep 17 00:00:00 2001 From: Bernd Bestel Date: Mon, 22 Aug 2022 23:58:34 +0200 Subject: [PATCH] Fixed qu_id_stock change handling related to product_barcode amounts (fixes #1976) --- changelog/69_UNRELEASED_xxxx-xx-xx.md | 1 + migrations/0197.sql | 5 ----- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/changelog/69_UNRELEASED_xxxx-xx-xx.md b/changelog/69_UNRELEASED_xxxx-xx-xx.md index d0ec3d4a..81a07961 100644 --- a/changelog/69_UNRELEASED_xxxx-xx-xx.md +++ b/changelog/69_UNRELEASED_xxxx-xx-xx.md @@ -16,6 +16,7 @@ - Fixed that adding Userfields to existing stock entries was not possible (only editing existing Userfield values, e.g. added during purchase or inventory, was possible) - Fixed that it was not possible to change a products stock QU, when the needed unit conversion (old QU => new QU) was only defined globally (means on QU level) or by the products "Factor purchase to stock quantity unit" - Fixed that when changing a products stock QU, the products "Quick consume mount", "Energy (kcal)" and "Tare weight" wasn't updated according to the corresponding unit conversion factor +- Fixed that when changing a products stock QU, the product barcode amounts were also changed based on the corresponding unit conversion factor ### Shopping list diff --git a/migrations/0197.sql b/migrations/0197.sql index 4ed15afb..1c007271 100644 --- a/migrations/0197.sql +++ b/migrations/0197.sql @@ -29,11 +29,6 @@ BEGIN WHERE type = 'product' AND product_id = NEW.id; - UPDATE product_barcodes - SET amount = amount * IFNULL((SELECT factor FROM quantity_unit_conversions_resolved WHERE product_id = NEW.id AND from_qu_id = OLD.qu_id_stock AND to_qu_id = NEW.qu_id_stock LIMIT 1), 1.0) - WHERE product_id = NEW.id - AND amount IS NOT NULL; - UPDATE recipes_pos SET amount = amount * IFNULL((SELECT factor FROM quantity_unit_conversions_resolved WHERE product_id = NEW.id AND from_qu_id = OLD.qu_id_stock AND to_qu_id = NEW.qu_id_stock LIMIT 1), 1.0) WHERE product_id = NEW.id;