From 46313e2c75a07999cc8d57c45876907e34206bff Mon Sep 17 00:00:00 2001
From: Bernd Bestel <bernd@berrnd.de>
Date: Sun, 4 Dec 2022 12:33:12 +0100
Subject: [PATCH] Applied code formatting rules for #2056

---
 migrations/0203.sql | 132 ++++++++++++++++++++++++++------------------
 1 file changed, 78 insertions(+), 54 deletions(-)

diff --git a/migrations/0203.sql b/migrations/0203.sql
index 05398902..cae411d1 100644
--- a/migrations/0203.sql
+++ b/migrations/0203.sql
@@ -1,25 +1,34 @@
-DROP VIEW IF EXISTS quantity_unit_conversions_resolved;
+DROP VIEW quantity_unit_conversions_resolved;
 
-CREATE VIEW quantity_unit_conversions_resolved AS
-WITH RECURSIVE
+CREATE VIEW quantity_unit_conversions_resolved
+AS
 
--- First, determine conversions that are a single step.
--- There may be multiple definitions for conversions between two units
--- (e.g. due to purchase-to-stock, product-specific and default conversions),
--- thus priorities are used to disambiguate conversions.
--- Later, we'll only use the factor with the highest priority to convert between two units.
+/*
+	First, determine conversions that are a single step.
+	There may be multiple definitions for conversions between two units
+	(e.g. due to purchase-to-stock, product-specific and default conversions),
+	thus priorities are used to disambiguate conversions.
+	Later, we'll only use the factor with the highest priority to convert between two units.
+*/
 
-	conversion_factors_dup(product_id, from_qu_id, to_qu_id, factor, priority)
+WITH RECURSIVE conversion_factors_dup(product_id, from_qu_id, to_qu_id, factor, priority)
 AS (
 	-- 1. Product "purchase to stock" factors ...
 	SELECT
-		p.id, p.qu_id_purchase, p.qu_id_stock, p.qu_factor_purchase_to_stock, 50
+		p.id,
+		p.qu_id_purchase,
+		p.qu_id_stock,
+		p.qu_factor_purchase_to_stock,
+		50
 	FROM products p
 	WHERE p.qu_id_stock != p.qu_id_purchase
-	UNION
-	-- ... and the inverse factors
+	UNION -- ... and the inverse factors
 	SELECT
-		p.id, p.qu_id_stock, p.qu_id_purchase, 1.0 / p.qu_factor_purchase_to_stock, 50
+		p.id,
+		p.qu_id_stock,
+		p.qu_id_purchase,
+		1.0 / p.qu_factor_purchase_to_stock,
+		50
 	FROM products p
 	WHERE p.qu_id_stock != p.qu_id_purchase
 
@@ -28,39 +37,51 @@ AS (
 	-- 2. Product specific QU overrides
 	-- Note that the quantity_unit_conversions table already contains both conversion directions for every conversion.
 	SELECT
-		product_id, from_qu_id, to_qu_id, factor, 30
+		product_id,
+		from_qu_id,
+		to_qu_id,
+		factor,
+		30
 	FROM quantity_unit_conversions
 	WHERE product_id IS NOT NULL
 
 	UNION
 
-	-- 3. Default QU conversions are handled in a later CTE, as we can't determine yet, for which products they are
-	-- applicable.
+	-- 3. Default QU conversions are handled in a later CTE, as we can't determine yet, for which products they are applicable.
 	SELECT
-		product_id, from_qu_id, to_qu_id, factor, 10
+		product_id,
+		from_qu_id,
+		to_qu_id,
+		factor,
+		10
 	FROM quantity_unit_conversions
 	WHERE product_id IS NULL
 ),
 
 -- Now, remove duplicate conversions, only retaining the entries with the highest priority
-	conversion_factors(product_id, from_qu_id, to_qu_id, factor)
+conversion_factors(product_id, from_qu_id, to_qu_id, factor)
 AS (
-	SELECT product_id, from_qu_id, to_qu_id,
-	       first_value(factor) OVER win
+	SELECT
+		product_id,
+		from_qu_id,
+		to_qu_id,
+		FIRST_VALUE(factor) OVER win
 	FROM conversion_factors_dup
 	GROUP BY product_id, from_qu_id, to_qu_id
-	WINDOW win AS (PARTITION BY product_id, from_qu_id, to_qu_id ORDER BY priority DESC)
+	WINDOW win AS(PARTITION BY product_id, from_qu_id, to_qu_id ORDER BY priority DESC)
 ),
 
 -- Now build the closure of posisble conversions using a recursive CTE
-	closure(depth, product_id, path, from_qu_id, to_qu_id, factor)
+closure(depth, product_id, path, from_qu_id, to_qu_id, factor)
 AS (
 	-- As a base case, select the conversions that refer to a concrete product
 	SELECT
-		1 as depth, product_id,
-		-- We need to keep track of the conversion path in order to prevent cycles
-		'/' || from_qu_id || '/' || to_qu_id || '/',
-		from_qu_id, to_qu_id, factor
+		1 as depth,
+		product_id,
+		'/' || from_qu_id || '/' || to_qu_id || '/', -- We need to keep track of the conversion path in order to prevent cycles
+		from_qu_id,
+		to_qu_id,
+		factor
 	FROM conversion_factors
 	WHERE product_id IS NOT NULL
 
@@ -68,13 +89,15 @@ AS (
 
 	-- First recursive case: Add a product-associated conversion to the chain
 	SELECT
-		c.depth + 1, c.product_id,
+		c.depth + 1,
+		c.product_id,
 		c.path || s.to_qu_id || '/',
-		c.from_qu_id, s.to_qu_id,
+		c.from_qu_id,
+		s.to_qu_id,
 		c.factor * s.factor
 	FROM closure c
 	JOIN conversion_factors s
-		ON  c.product_id = s.product_id -- c.product_id IS NOT NULL
+		ON c.product_id = s.product_id
 		AND c.to_qu_id = s.from_qu_id
 	WHERE c.path NOT LIKE ('%/' || s.to_qu_id || '/%') -- prevent cycles
 
@@ -82,33 +105,35 @@ AS (
 
 	-- Second recursive case: Add a default unit conversion to the *start* of the conversion chain
 	SELECT
-		c.depth + 1, c.product_id,
+		c.depth + 1,
+		c.product_id,
 		'/' || s.from_qu_id || c.path,
-		s.from_qu_id, c.to_qu_id,
+		s.from_qu_id,
+		c.to_qu_id,
 		s.factor * c.factor
 	FROM closure c
 	JOIN conversion_factors s
-		ON  s.to_qu_id = c.from_qu_id
+		ON s.to_qu_id = c.from_qu_id
 		AND s.product_id IS NULL
-	-- Do this only, if there is no product_specific conversion between the units in s
-	WHERE   NOT EXISTS(SELECT 1 FROM conversion_factors ci WHERE ci.product_id = c.product_id AND ci.from_qu_id = s.from_qu_id AND ci.to_qu_id = s.to_qu_id)
-		AND c.path NOT LIKE ('%/' || s.from_qu_id || '/%')
+	WHERE NOT EXISTS(SELECT 1 FROM conversion_factors ci WHERE ci.product_id = c.product_id AND ci.from_qu_id = s.from_qu_id AND ci.to_qu_id = s.to_qu_id) -- Do this only, if there is no product_specific conversion between the units in s
+	AND c.path NOT LIKE ('%/' || s.from_qu_id || '/%')
 
 	UNION
 
 	-- Third recursive case: Add a default unit conversion to the *end* of the conversion chain
 	SELECT
-		c.depth + 1, c.product_id,
+		c.depth + 1,
+		c.product_id,
 		c.path || s.to_qu_id || '/',
-		c.from_qu_id, s.to_qu_id,
+		c.from_qu_id,
+		s.to_qu_id,
 		c.factor * s.factor
 	FROM closure c
 	JOIN conversion_factors s
-		ON  c.to_qu_id = s.from_qu_id
+		ON c.to_qu_id = s.from_qu_id
 		AND s.product_id IS NULL
-	-- Do this only, if there is no product_specific conversion between the units in s
-	WHERE   NOT EXISTS(SELECT 1 FROM conversion_factors ci WHERE ci.product_id = c.product_id AND ci.from_qu_id = s.from_qu_id AND ci.to_qu_id = s.to_qu_id)
-		AND c.path NOT LIKE ('%/' || s.to_qu_id || '/%')
+	WHERE NOT EXISTS(SELECT 1 FROM conversion_factors ci WHERE ci.product_id = c.product_id AND ci.from_qu_id = s.from_qu_id AND ci.to_qu_id = s.to_qu_id) -- Do this only, if there is no product_specific conversion between the units in s
+	AND c.path NOT LIKE ('%/' || s.to_qu_id || '/%')
 
 	UNION
 
@@ -122,25 +147,24 @@ AS (
 		s.from_qu_id, s.to_qu_id,
 		s.factor
 	FROM closure c, conversion_factors s
-	WHERE   NOT EXISTS(SELECT 1 FROM conversion_factors ci WHERE ci.product_id = c.product_id AND ci.from_qu_id = s.from_qu_id AND ci.to_qu_id = s.to_qu_id)
-		AND c.path LIKE ('%/' || s.from_qu_id || '/' || s.to_qu_id || '/%')
+	WHERE NOT EXISTS(SELECT 1 FROM conversion_factors ci WHERE ci.product_id = c.product_id AND ci.from_qu_id = s.from_qu_id AND ci.to_qu_id = s.to_qu_id)
+	AND c.path LIKE ('%/' || s.from_qu_id || '/' || s.to_qu_id || '/%')
 )
 
 SELECT DISTINCT
 	-1 AS id, -- Dummy, LessQL needs an id column
 	c.product_id,
 	c.from_qu_id,
-	qu_from.name        AS from_qu_name,
+	qu_from.name AS from_qu_name,
 	qu_from.name_plural AS from_qu_name_plural,
 	c.to_qu_id,
-	qu_to.name          AS to_qu_name,
-	qu_to.name_plural   AS to_qu_name_plural,
-	first_value(factor) OVER (PARTITION BY product_id, from_qu_id, to_qu_id ORDER BY depth ASC) AS factor,
-	c.path              AS source
+	qu_to.name AS to_qu_name,
+	qu_to.name_plural AS to_qu_name_plural,
+	FIRST_VALUE(factor) OVER (PARTITION BY product_id, from_qu_id, to_qu_id ORDER BY depth ASC) AS factor,
+	c.path AS source
 FROM closure c
-	JOIN quantity_units qu_from
-		ON c.from_qu_id = qu_from.id
-	JOIN quantity_units qu_to
-		ON c.to_qu_id = qu_to.id
-ORDER BY
-	product_id, from_qu_id, to_qu_id;
+JOIN quantity_units qu_from
+	ON c.from_qu_id = qu_from.id
+JOIN quantity_units qu_to
+	ON c.to_qu_id = qu_to.id
+ORDER BY product_id, from_qu_id, to_qu_id;