kenmirrors/grocy
1
0
Fork 0
mirror of https://github.com/grocy/grocy.git synced 2025-08-16 02:34:44 +00:00
Code Issues Projects Releases Wiki Activity

Revert "Return numbers as numbers on all API endpoints" (14cd6ca3bf, fixes #1564)

Browse Source
This commit is contained in:
Bernd Bestel
2021-08-20 21:45:56 +02:00
parent 1d5ca5ed64
commit 2c0b6368e1
3 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
changelog/62_3.1.0_2021-07-16.md
View File

@@ -114,6 +114,8 @@
### API improvements/fixes ### API improvements/fixes
> ❗ Numbers are now returned as numbers (so technically without quotes around them, were strings for nearly all endpoints before - should practically be no real difference) > ❗ Numbers are now returned as numbers (so technically without quotes around them, were strings for nearly all endpoints before - should practically be no real difference)
>
> => ❗❗❗ This has been reverted after this (v3.1.0) release since it had unintended side effects
- Added a new endpoint `/system/localization-strings` to get the localization strings (gettext JSON representation; in the by the user desired language) - Added a new endpoint `/system/localization-strings` to get the localization strings (gettext JSON representation; in the by the user desired language)
- Added a new endpoint `/recipes/{recipeId}/copy` to copy a recipe - Added a new endpoint `/recipes/{recipeId}/copy` to copy a recipe
- The `GET /chores` endpoint now also returns the `next_execution_assigned_user` object per chore (like the endpoint `GET /chores​/{choreId}` already did for a single chore) - The `GET /chores` endpoint now also returns the `next_execution_assigned_user` object per chore (like the endpoint `GET /chores​/{choreId}` already did for a single chore)

9
changelog/63_UNRELEASED_xxxx.xx.xx.md
View File

@@ -2,12 +2,15 @@
- Fixed that when having any "Track date only" chore on the calendar, the iCal export was broken - Fixed that when having any "Track date only" chore on the calendar, the iCal export was broken
- Fixed that the upgrade failed when having unsupported parent/child product nesting levels - Fixed that the upgrade failed when having unsupported parent/child product nesting levels
- More information on this: Only 1 level is currently supported; creating > 1 level nestings was _never_ possible via the UI/frontend, but not checked/enforced by the backend before `v3.0.0` - so it was potentially possible via the API (or any third party app/tool which utilizes it) to create such a nesting which then made this upgrade to fail - More information on this: Only 1 level is currently supported; creating > 1 level nestings was _never_ possible via the UI/frontend, but not checked/enforced by the backend before `v3.0.0` - so it was potentially possible via the API (or any third party app/tool which utilizes it) to create such a nesting which then made this upgrade to fail
- Fixed that the "Stock by-barcode" API routes were broken (thanks @larsverp)
- Fixed that the "Stock by-barcode" API routes also accepted chore or battery grocycodes (thanks @lowlee)
- Fixed that it was not possible to select a chore/battery on the corresponding tracking pages by mouse/touch - Fixed that it was not possible to select a chore/battery on the corresponding tracking pages by mouse/touch
- Fixed that grouping by columns in tables may caused duplicate groups - Fixed that grouping by columns in tables may caused duplicate groups
- Fixed that grocycode camera barcode scanning didn't recognize the scanned code for chore/battery tracking - Fixed that grocycode camera barcode scanning didn't recognize the scanned code for chore/battery tracking
- Optimized the meal plan page to be properly printable (thanks @MrKrisKrisu)
### API
> ❗ The release before (v3.1.0) introduced that "numbers are now returned as numbers": **This was reverted** since it had unintended side effects (so all fields are technically strings now again, just like before - sorry for that)
- Fixed that `missing_products` of the `/stock/volatile` endpoint also returned incactive products - Fixed that `missing_products` of the `/stock/volatile` endpoint also returned incactive products
- Fixed that when having multiple Userfields for an entity, the `/objects/{entity}` endpoint returned wrong Userfield values - Fixed that when having multiple Userfields for an entity, the `/objects/{entity}` endpoint returned wrong Userfield values
- Fixed that the `/stock/products/by-barcode/{barcode}/consume` and `/stock/products/by-barcode/{barcode}/transfer` haven't used the stock entry given by a stock entry grocycode (thanks @lowlee for the initial work on this) - Fixed that the `/stock/products/by-barcode/{barcode}/consume` and `/stock/products/by-barcode/{barcode}/transfer` haven't used the stock entry given by a stock entry grocycode (thanks @lowlee for the initial work on this)
- Optimized the meal plan page to be properly printable (thanks @MrKrisKrisu) - Fixed that the "Stock by-barcode" API routes were broken (thanks @larsverp)
- Fixed that the "Stock by-barcode" API routes also accepted chore or battery grocycodes (thanks @lowlee)

2
controllers/BaseApiController.php
View File

@@ -21,7 +21,7 @@ class BaseApiController extends BaseController
$response = $response->withHeader('Cache-Control', 'max-age=2592000'); $response = $response->withHeader('Cache-Control', 'max-age=2592000');
} }
$response->getBody()->write(json_encode($data, JSON_NUMERIC_CHECK)); $response->getBody()->write(json_encode($data));
return $response; return $response;
} }