kenmirrors/grocy
1
0
Fork 0
mirror of https://github.com/grocy/grocy.git synced 2025-08-20 20:26:42 +00:00
Code Issues Projects Releases Wiki Activity

Handle image URLs with query parameters returned from an external barcode lookup plugin

Browse Source
This commit is contained in:
Bernd Bestel
2025-03-04 20:40:48 +01:00
parent 46253c455f
commit 2a3e23ded4
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
changelog/80_UNRELEASED_xxxx-xx-xx.md
View File

@@ -13,6 +13,7 @@
- Optimizations in the built-in Open Food Facts external barcode lookup plugin: - Optimizations in the built-in Open Food Facts external barcode lookup plugin:
- A provided but empty localized product name is now ignored - A provided but empty localized product name is now ignored
- Non-ASCII characters in product names are now ignored (e.g. line breaks caused problems) - Non-ASCII characters in product names are now ignored (e.g. line breaks caused problems)
- Optimized that when an external barcode lookup plugin returned an image URL with query parameters, an invalid picture (file name) was added to the created product
### Shopping list ### Shopping list

2
services/StockService.php
View File

@@ -626,7 +626,7 @@ class StockService extends BaseService
{ {
$webClient = new Client(); $webClient = new Client();
$response = $webClient->request('GET', $pluginOutput['__image_url'], ['headers' => ['User-Agent' => 'Grocy/' . $this->getApplicationService()->GetInstalledVersion()->Version . ' (https://grocy.info)']]); $response = $webClient->request('GET', $pluginOutput['__image_url'], ['headers' => ['User-Agent' => 'Grocy/' . $this->getApplicationService()->GetInstalledVersion()->Version . ' (https://grocy.info)']]);
$fileName = $pluginOutput['__barcode'] . '.' . pathinfo($pluginOutput['__image_url'], PATHINFO_EXTENSION); $fileName = $pluginOutput['__barcode'] . '.' . pathinfo(parse_url($pluginOutput['__image_url'], PHP_URL_PATH), PATHINFO_EXTENSION);
file_put_contents($this->getFilesService()->GetFilePath('productpictures', $fileName), $response->getBody()); file_put_contents($this->getFilesService()->GetFilePath('productpictures', $fileName), $response->getBody());
$productData['picture_file_name'] = $fileName; $productData['picture_file_name'] = $fileName;
} }