From 03271881256ea9ca0753a9b53771f477f3bbce24 Mon Sep 17 00:00:00 2001 From: Bernd Bestel Date: Sun, 12 Apr 2020 18:41:23 +0200 Subject: [PATCH] Optimize datetimepicker form validation events (fixes #726) --- changelog/58_UNRELEASED_2020-xx-xx.md | 1 + public/viewjs/components/datetimepicker.js | 2 ++ public/viewjs/components/datetimepicker2.js | 2 ++ 3 files changed, 5 insertions(+) diff --git a/changelog/58_UNRELEASED_2020-xx-xx.md b/changelog/58_UNRELEASED_2020-xx-xx.md index e41650c1..e01314f9 100644 --- a/changelog/58_UNRELEASED_2020-xx-xx.md +++ b/changelog/58_UNRELEASED_2020-xx-xx.md @@ -32,6 +32,7 @@ ### General & other improvements/fixes - Fixed that all number inputs are always prefilled in the browser locale number format - Fixed (again) that the `update.sh` file had wrong line endings (DOS instead of Unix) +- Optimized that sometimes the corresponding form was not validated when selecting a date from the datetimepicker - New `config.php` setting `FEATURE_FLAG_STOCK_BEST_BEFORE_DATE_FIELD_NUMBER_PAD` which activates the number pad for best-before-date fields on (supported) mobile browsers (useful because of [shorthands](https://github.com/grocy/grocy#input-shorthands-for-date-fields)) (defaults to `true`) (thanks @Mik-) - Enhancements for the camera barcode scanner (thanks @Mik-) - The light button only displayed when the device has a flash light diff --git a/public/viewjs/components/datetimepicker.js b/public/viewjs/components/datetimepicker.js index 6a43566d..3b415016 100644 --- a/public/viewjs/components/datetimepicker.js +++ b/public/viewjs/components/datetimepicker.js @@ -276,6 +276,7 @@ $('.datetimepicker').on('update.datetimepicker', function(e) Grocy.Components.DateTimePicker.GetInputElement().trigger('input'); Grocy.Components.DateTimePicker.GetInputElement().trigger('change'); Grocy.Components.DateTimePicker.GetInputElement().trigger('keypress'); + Grocy.Components.DateTimePicker.GetInputElement().trigger('keyup'); }); $('.datetimepicker').on('hide.datetimepicker', function(e) @@ -283,6 +284,7 @@ $('.datetimepicker').on('hide.datetimepicker', function(e) Grocy.Components.DateTimePicker.GetInputElement().trigger('input'); Grocy.Components.DateTimePicker.GetInputElement().trigger('change'); Grocy.Components.DateTimePicker.GetInputElement().trigger('keypress'); + Grocy.Components.DateTimePicker.GetInputElement().trigger('keyup'); }); $("#datetimepicker-shortcut").on("click", function() diff --git a/public/viewjs/components/datetimepicker2.js b/public/viewjs/components/datetimepicker2.js index 24e4650b..015f2ee3 100644 --- a/public/viewjs/components/datetimepicker2.js +++ b/public/viewjs/components/datetimepicker2.js @@ -276,6 +276,7 @@ $('.datetimepicker2').on('update.datetimepicker', function(e) Grocy.Components.DateTimePicker2.GetInputElement().trigger('input'); Grocy.Components.DateTimePicker2.GetInputElement().trigger('change'); Grocy.Components.DateTimePicker2.GetInputElement().trigger('keypress'); + Grocy.Components.DateTimePicker2.GetInputElement().trigger('keyup'); }); $('.datetimepicker2').on('hide.datetimepicker', function(e) @@ -283,6 +284,7 @@ $('.datetimepicker2').on('hide.datetimepicker', function(e) Grocy.Components.DateTimePicker2.GetInputElement().trigger('input'); Grocy.Components.DateTimePicker2.GetInputElement().trigger('change'); Grocy.Components.DateTimePicker2.GetInputElement().trigger('keypress'); + Grocy.Components.DateTimePicker2.GetInputElement().trigger('keyup'); }); $("#datetimepicker2-shortcut").on("click", function()