Code clean up.

This commit is contained in:
James Cole
2017-11-15 12:25:49 +01:00
parent 57dcdfa0c4
commit ffca858b8d
476 changed files with 2055 additions and 4181 deletions

View File

@@ -18,7 +18,6 @@
* You should have received a copy of the GNU General Public License
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
*/
declare(strict_types=1);
namespace FireflyIII\TransactionRules\Actions;
@@ -31,15 +30,12 @@ use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
use Log;
/**
* Class SetBudget
*
* @package FireflyIII\TransactionRules\Action
* Class SetBudget.
*/
class SetBudget implements ActionInterface
{
private $action;
/**
* TriggerInterface constructor.
*
@@ -67,13 +63,13 @@ class SetBudget implements ActionInterface
return $current->name === $search;
}
)->first();
if (is_null($budget)) {
if (null === $budget) {
Log::debug(sprintf('RuleAction SetBudget could not set budget of journal #%d to "%s" because no such budget exists.', $journal->id, $search));
return true;
}
if ($journal->transactionType->type !== TransactionType::WITHDRAWAL) {
if (TransactionType::WITHDRAWAL !== $journal->transactionType->type) {
Log::debug(
sprintf(
'RuleAction SetBudget could not set budget of journal #%d to "%s" because journal is a %s.',
@@ -90,7 +86,6 @@ class SetBudget implements ActionInterface
$journal->budgets()->sync([$budget->id]);
return true;
}
}