Code clean up.

This commit is contained in:
James Cole
2017-11-15 12:25:49 +01:00
parent 57dcdfa0c4
commit ffca858b8d
476 changed files with 2055 additions and 4181 deletions

View File

@@ -18,7 +18,6 @@
* You should have received a copy of the GNU General Public License
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
*/
declare(strict_types=1);
namespace FireflyIII\Models;
@@ -31,9 +30,7 @@ use Illuminate\Database\Eloquent\SoftDeletes;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
/**
* Class Attachment
*
* @package FireflyIII\Models
* Class Attachment.
*/
class Attachment extends Model
{
@@ -59,7 +56,7 @@ class Attachment extends Model
*
* @return Attachment
*/
public static function routeBinder(Attachment $value)
public static function routeBinder(self $value)
{
if (auth()->check()) {
if (intval($value->user_id) === auth()->user()->id) {
@@ -96,7 +93,7 @@ class Attachment extends Model
*/
public function getDescriptionAttribute($value)
{
if (is_null($value) || strlen($value) === 0) {
if (null === $value || 0 === strlen($value)) {
return null;
}
@@ -110,7 +107,7 @@ class Attachment extends Model
*/
public function getFilenameAttribute($value)
{
if (is_null($value) || strlen($value) === 0) {
if (null === $value || 0 === strlen($value)) {
return null;
}
@@ -124,7 +121,7 @@ class Attachment extends Model
*/
public function getMimeAttribute($value)
{
if (is_null($value) || strlen($value) === 0) {
if (null === $value || 0 === strlen($value)) {
return null;
}
@@ -132,14 +129,13 @@ class Attachment extends Model
}
/**
*
* @param $value
*
* @return null|string
*/
public function getNotesAttribute($value)
{
if (is_null($value) || strlen($value) === 0) {
if (null === $value || 0 === strlen($value)) {
return null;
}
@@ -147,14 +143,13 @@ class Attachment extends Model
}
/**
*
* @param $value
*
* @return null|string
*/
public function getTitleAttribute($value)
{
if (is_null($value) || strlen($value) === 0) {
if (null === $value || 0 === strlen($value)) {
return null;
}