kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-16 09:22:33 +00:00
Code Issues Projects Releases Wiki Activity

Fix #9863

Browse Source
This commit is contained in:
James Cole
2025-02-20 07:28:24 +01:00
parent adbf6defe5
commit f7f317a3b2
1 changed files with 50 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
app/Support/Preferences.php
View File

@@ -52,8 +52,7 @@ class Preferences
$q->whereNull('user_group_id'); $q->whereNull('user_group_id');
$q->orWhere('user_group_id', $user->user_group_id); $q->orWhere('user_group_id', $user->user_group_id);
}) })
->get() ->get();
;
} }
public function get(string $name, null | array | bool | int | string $default = null): ?Preference public function get(string $name, null | array | bool | int | string $default = null): ?Preference
@@ -72,20 +71,30 @@ class Preferences
public function getForUser(User $user, string $name, null | array | bool | int | string $default = null): ?Preference public function getForUser(User $user, string $name, null | array | bool | int | string $default = null): ?Preference
{ {
Log::debug(sprintf('getForUser(#%d, "%s")', $user->id, $name));
// don't care about user group ID, except for some specific preferences. // don't care about user group ID, except for some specific preferences.
$userGroupId = $this->getUserGroupId($user, $name); $userGroupId = $this->getUserGroupId($user, $name);
$preference = Preference::where('user_group_id', $userGroupId)->where('user_id', $user->id)->where('name', $name)->first(['id', 'user_id', 'name', 'data', 'updated_at', 'created_at']); $query = Preference::where('user_id', $user->id)->where('name', $name);
if (null !== $userGroupId) {
Log::debug('Include user group ID in query');
$query->where('user_group_id', $userGroupId);
}
$preference = $query->first(['id', 'user_id', 'user_group_id', 'name', 'data', 'updated_at', 'created_at']);
if (null !== $preference && null === $preference->data) { if (null !== $preference && null === $preference->data) {
$preference->delete(); $preference->delete();
$preference = null; $preference = null;
Log::debug('Removed empty preference.');
} }
if (null !== $preference) { if (null !== $preference) {
Log::debug(sprintf('Found preference #%d for user #%d: %s', $preference->id, $user->id, $name));
return $preference; return $preference;
} }
// no preference found and default is null: // no preference found and default is null:
if (null === $default) { if (null === $default) {
Log::debug('Return NULL, create no preference.');
// return NULL // return NULL
return null; return null;
} }
@@ -125,34 +134,39 @@ class Preferences
public function setForUser(User $user, string $name, null | array | bool | int | string $value): Preference public function setForUser(User $user, string $name, null | array | bool | int | string $value): Preference
{ {
$fullName = sprintf('preference%s%s', $user->id, $name); $fullName = sprintf('preference%s%s', $user->id, $name);
$groupId = $this->getUserGroupId($user, $name); $userGroupId = $this->getUserGroupId($user, $name);
$groupId = 0 === (int) $groupId ? null : (int) $groupId; $userGroupId = 0 === (int) $userGroupId ? null : (int) $userGroupId;
Cache::forget($fullName); Cache::forget($fullName);
/** @var null|Preference $pref */ $query = Preference::where('user_id', $user->id)->where('name', $name);
$pref = Preference::where('user_group_id', $groupId)->where('user_id', $user->id)->where('name', $name)->first(['id', 'name', 'data', 'updated_at', 'created_at']); if (null !== $userGroupId) {
Log::debug('Include user group ID in query');
$query->where('user_group_id', $userGroupId);
}
if (null !== $pref && null === $value) { $preference = $query->first(['id', 'user_id', 'user_group_id', 'name', 'data', 'updated_at', 'created_at']);
$pref->delete();
if (null !== $preference && null === $value) {
$preference->delete();
return new Preference(); return new Preference();
} }
if (null === $value) { if (null === $value) {
return new Preference(); return new Preference();
} }
if (null === $pref) { if (null === $preference) {
$pref = new Preference(); $preference = new Preference();
$pref->user_id = (int) $user->id; $preference->user_id = (int) $user->id;
$pref->user_group_id = $groupId; $preference->user_group_id = $userGroupId;
$pref->name = $name; $preference->name = $name;
} }
$pref->data = $value; $preference->data = $value;
$pref->save(); $preference->save();
Cache::forever($fullName, $pref); Cache::forever($fullName, $preference);
return $pref; return $preference;
} }
public function beginsWith(User $user, string $search): Collection public function beginsWith(User $user, string $search): Collection
@@ -179,8 +193,7 @@ class Preferences
$q->orWhere('user_group_id', $user->user_group_id); $q->orWhere('user_group_id', $user->user_group_id);
}) })
->whereIn('name', $list) ->whereIn('name', $list)
->get(['id', 'name', 'data']) ->get(['id', 'name', 'data']);
;
/** @var Preference $preference */ /** @var Preference $preference */
foreach ($preferences as $preference) { foreach ($preferences as $preference) {