kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-18 18:40:12 +00:00
Code Issues Projects Releases Wiki Activity

Fix: nullpointer in billrepository.

Browse Source
This commit is contained in:
James Cole
2023-06-18 06:26:38 +02:00
parent e72a483c49
commit f75e6430b1
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/Repositories/Bill/BillRepository.php
View File

@@ -709,14 +709,16 @@ class BillRepository implements BillRepositoryInterface
/** @var TransactionJournal $transactionJournal */ /** @var TransactionJournal $transactionJournal */
foreach ($set as $transactionJournal) { foreach ($set as $transactionJournal) {
/** @var Transaction $sourceTransaction */ /** @var Transaction|null $sourceTransaction */
$sourceTransaction = $transactionJournal->transactions()->where('amount', '<', 0)->first(); $sourceTransaction = $transactionJournal->transactions()->where('amount', '<', 0)->first();
$amount = (string)$sourceTransaction->amount; if (null !== $sourceTransaction) {
if ((int)$sourceTransaction->foreign_currency_id === (int)$currency->id) { $amount = (string)$sourceTransaction->amount;
// use foreign amount instead! if ((int)$sourceTransaction->foreign_currency_id === (int)$currency->id) {
$amount = (string)$sourceTransaction->foreign_amount; // use foreign amount instead!
$amount = (string)$sourceTransaction->foreign_amount;
}
$return[$currency->id]['sum'] = bcadd($return[$currency->id]['sum'], $amount);
} }
$return[$currency->id]['sum'] = bcadd($return[$currency->id]['sum'], $amount);
} }
} }
return $return; return $return;