mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2025-11-02 03:51:18 +00:00
Remove TODO's, add some suppressors for code quality.
This commit is contained in:
@@ -68,8 +68,6 @@ class IndexController extends Controller
|
||||
/**
|
||||
* Show all budgets.
|
||||
*
|
||||
* TODO remove moment routine.
|
||||
*
|
||||
* @param Request $request
|
||||
* @param string|null $moment
|
||||
*
|
||||
|
||||
@@ -518,8 +518,6 @@ class BudgetController extends Controller
|
||||
/**
|
||||
* Small helper function for some of the charts. Extracts category names from a bunch of ID's.
|
||||
*
|
||||
* TODO this method is duplicated and should be in a trait.
|
||||
*
|
||||
* @param array $categoryIds
|
||||
*
|
||||
* @return array
|
||||
|
||||
@@ -121,8 +121,6 @@ class Controller extends BaseController
|
||||
/**
|
||||
* Is transaction opening balance?
|
||||
*
|
||||
* TODO move to trait.
|
||||
*
|
||||
* @param TransactionJournal $journal
|
||||
*
|
||||
* @return bool
|
||||
@@ -136,8 +134,6 @@ class Controller extends BaseController
|
||||
/**
|
||||
* Redirect to asset account that transaction belongs to.
|
||||
*
|
||||
* TODO move to trait.
|
||||
*
|
||||
* @param TransactionJournal $journal
|
||||
*
|
||||
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
|
||||
@@ -172,9 +168,6 @@ class Controller extends BaseController
|
||||
|
||||
/**
|
||||
* Get user's language.
|
||||
*
|
||||
* TODO pretty sure nobody uses this.
|
||||
*
|
||||
* @return string
|
||||
*/
|
||||
private function getLanguage(): string
|
||||
@@ -196,8 +189,6 @@ class Controller extends BaseController
|
||||
/**
|
||||
* Get the specific name of a page for intro.
|
||||
*
|
||||
* TODO move to trait.
|
||||
*
|
||||
* @return string
|
||||
*/
|
||||
private function getSpecificPageName(): string
|
||||
@@ -208,8 +199,6 @@ class Controller extends BaseController
|
||||
/**
|
||||
* Returns if user has seen demo.
|
||||
*
|
||||
* TODO move to trait.
|
||||
*
|
||||
* @return bool
|
||||
*/
|
||||
private function hasSeenDemo(): bool
|
||||
|
||||
@@ -107,8 +107,6 @@ class CurrencyController extends Controller
|
||||
app('preferences')->mark();
|
||||
|
||||
$request->session()->flash('success', (string)trans('firefly.new_default_currency', ['name' => $currency->name]));
|
||||
Cache::forget('FFCURRENCYSYMBOL'); // todo are these even used?
|
||||
Cache::forget('FFCURRENCYCODE');
|
||||
|
||||
return redirect(route('currencies.index'));
|
||||
}
|
||||
|
||||
@@ -68,8 +68,6 @@ class HelpController extends Controller
|
||||
/**
|
||||
* Gets the help text.
|
||||
*
|
||||
* TODO move to repos or trait.
|
||||
*
|
||||
* @param string $route
|
||||
* @param string $language
|
||||
*
|
||||
|
||||
@@ -70,9 +70,6 @@ class EditController extends Controller
|
||||
/**
|
||||
* Edit a recurring transaction.
|
||||
*
|
||||
* todo move to repository
|
||||
* todo handle old repetition type as well.
|
||||
*
|
||||
* @param Request $request
|
||||
* @param Recurrence $recurrence
|
||||
*
|
||||
|
||||
@@ -65,8 +65,6 @@ class IndexController extends Controller
|
||||
/**
|
||||
* Show all recurring transactions.
|
||||
*
|
||||
* TODO: split collection into pages
|
||||
*
|
||||
* @param Request $request
|
||||
*
|
||||
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
|
||||
|
||||
@@ -38,8 +38,6 @@ class BudgetController extends Controller
|
||||
/**
|
||||
* Show partial overview of budgets.
|
||||
*
|
||||
* TODO replace all \Throwable by catch/error and return simple string.
|
||||
*
|
||||
* @param Collection $accounts
|
||||
* @param Carbon $start
|
||||
* @param Carbon $end
|
||||
|
||||
@@ -71,8 +71,6 @@ class CreateController extends Controller
|
||||
/**
|
||||
* Create a new rule. It will be stored under the given $ruleGroup.
|
||||
*
|
||||
* TODO remove bill from this method, move to separate routine.
|
||||
*
|
||||
* @param Request $request
|
||||
* @param RuleGroup $ruleGroup
|
||||
*
|
||||
|
||||
@@ -172,8 +172,6 @@ class TagController extends Controller
|
||||
* @param Tag $tag
|
||||
* @param string|null $moment
|
||||
*
|
||||
* TODO will be cleaned up and separated
|
||||
*
|
||||
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
|
||||
*
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
|
||||
Reference in New Issue
Block a user