kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-16 17:33:45 +00:00
Code Issues Projects Releases Wiki Activity

Fix #3182

Browse Source
This commit is contained in:
James Cole
2020-03-11 06:41:02 +01:00
parent bccde86c0c
commit dd84c7f966
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/Factory/TransactionFactory.php
View File

@@ -108,6 +108,9 @@ class TransactionFactory
*/ */
public function createNegative(string $amount, ?string $foreignAmount): ?Transaction public function createNegative(string $amount, ?string $foreignAmount): ?Transaction
{ {
if ('' === $foreignAmount) {
$foreignAmount = null;
}
if (null !== $foreignAmount) { if (null !== $foreignAmount) {
$foreignAmount = app('steam')->negative($foreignAmount); $foreignAmount = app('steam')->negative($foreignAmount);
} }
@@ -124,6 +127,9 @@ class TransactionFactory
*/ */
public function createPositive(string $amount, ?string $foreignAmount): ?Transaction public function createPositive(string $amount, ?string $foreignAmount): ?Transaction
{ {
if ('' === $foreignAmount) {
$foreignAmount = null;
}
if (null !== $foreignAmount) { if (null !== $foreignAmount) {
$foreignAmount = app('steam')->positive($foreignAmount); $foreignAmount = app('steam')->positive($foreignAmount);
} }
@@ -158,7 +164,10 @@ class TransactionFactory
private function create(string $amount, ?string $foreignAmount): ?Transaction private function create(string $amount, ?string $foreignAmount): ?Transaction
{ {
$result = null; $result = null;
$data = [ if ('' === $foreignAmount) {
$foreignAmount = null;
}
$data = [
'reconciled' => $this->reconciled, 'reconciled' => $this->reconciled,
'account_id' => $this->account->id, 'account_id' => $this->account->id,
'transaction_journal_id' => $this->journal->id, 'transaction_journal_id' => $this->journal->id,