kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-15 08:35:00 +00:00
Code Issues Projects Releases Wiki Activity

Clean up code.

Browse Source
This commit is contained in:
James Cole
2023-12-10 06:45:59 +01:00
parent 9a807fc215
commit c2b22a2bac
157 changed files with 648 additions and 669 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Support/Form/AccountForm.php
View File

@@ -132,7 +132,7 @@ class AccountForm
*/
public function assetAccountCheckList(string $name, array $options = null): string
{
$options = $options ?? [];
$options ??= [];
$label = $this->label($name, $options);
$options = $this->expandOptionArray($name, $label, $options);
$classes = $this->getHolderClasses($name);

8
app/Support/Form/FormSupport.php
View File

@@ -44,7 +44,7 @@ trait FormSupport
*/
public function select(string $name, array $list = null, $selected = null, array $options = null): string
{
$list = $list ?? [];
$list ??= [];
$label = $this->label($name, $options);
$options = $this->expandOptionArray($name, $label, $options);
$classes = $this->getHolderClasses($name);
@@ -68,7 +68,7 @@ trait FormSupport
*/
protected function label(string $name, array $options = null): string
{
$options = $options ?? [];
$options ??= [];
if (array_key_exists('label', $options)) {
return $options['label'];
}
@@ -86,7 +86,7 @@ trait FormSupport
*/
protected function expandOptionArray(string $name, $label, array $options = null): array
{
$options = $options ?? [];
$options ??= [];
$name = str_replace('[]', '', $name);
$options['class'] = 'form-control';
$options['id'] = 'ffInput_' . $name;
@@ -156,7 +156,7 @@ trait FormSupport
$date = null;
try {
$date = today(config('app.timezone'));
} catch (InvalidDateException $e) {
} catch (InvalidDateException $e) { // @phpstan-ignore-line
app('log')->error($e->getMessage());
}

2
app/Support/Form/PiggyBankForm.php
View File

@@ -71,7 +71,7 @@ class PiggyBankForm
$groupTitle = $group->title;
$groupOrder = $group->order;
}
$subList[$groupOrder] = $subList[$groupOrder] ?? [
$subList[$groupOrder] ??= [
'group' => [
'title' => $groupTitle,
],

2
app/Support/Form/RuleForm.php
View File

@@ -67,7 +67,7 @@ class RuleForm
*/
public function ruleGroupListWithEmpty(string $name, $value = null, array $options = null): string
{
$options = $options ?? [];
$options ??= [];
$options['class'] = 'form-control';
/** @var RuleGroupRepositoryInterface $groupRepos */
$groupRepos = app(RuleGroupRepositoryInterface::class);