From ba9968bde0a392184ce31ce4c785d92f538e4a5f Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 22:53:03 +0100 Subject: [PATCH] Fixed a bug in "number between" tests. --- app/tests/factories/PiggyBank.php | 16 +++++++++++----- app/tests/factories/PiggyBankRepetition.php | 4 +++- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/app/tests/factories/PiggyBank.php b/app/tests/factories/PiggyBank.php index 18a18fc984..36f89debf8 100644 --- a/app/tests/factories/PiggyBank.php +++ b/app/tests/factories/PiggyBank.php @@ -4,7 +4,9 @@ League\FactoryMuffin\Facade::define( 'PiggyBank', [ 'account_id' => 'factory|Account', 'name' => 'word', - 'targetamount' => 'numberBetween|10;400', + 'targetamount' => function () { + return rand(1, 400); + }, 'startdate' => 'date|Y-m-d', 'targetdate' => 'date|Y-m-d', 'repeats' => 'boolean', @@ -13,16 +15,20 @@ League\FactoryMuffin\Facade::define( return $set[rand(0, count($set) - 1)]; }, - 'rep_every' => 'numberBetween:0,3', - 'rep_times' => 'numberBetween:0,3', + 'rep_every' => function() {return rand(0,3);}, + 'rep_times' => function() {return rand(0,3);}, 'reminder' => function () { $set = ['day', 'week', 'quarter', 'month', 'year']; return $set[rand(0, count($set) - 1)]; }, - 'reminder_skip' => 'numberBetween:0,3', + 'reminder_skip' => function () { + return rand(0, 3); + }, 'remind_me' => 'boolean', - 'order' => 'numberBetween:0,10', + 'order' => function () { + return rand(0, 10); + }, ] ); diff --git a/app/tests/factories/PiggyBankRepetition.php b/app/tests/factories/PiggyBankRepetition.php index dd1bbbaf76..a266af2283 100644 --- a/app/tests/factories/PiggyBankRepetition.php +++ b/app/tests/factories/PiggyBankRepetition.php @@ -5,7 +5,9 @@ League\FactoryMuffin\Facade::define( 'piggy_bank_id' => 'factory|PiggyBank', 'startdate' => 'date|Y-m-d', 'targetdate' => 'date|Y-m-d', - 'currentamount' => 'numberBetween:0,100', + 'currentamount' => function () { + return rand(0, 100); + }, ] );