From b263120c8f6761fb966b0a78b5f7d812dd7e0a2d Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 22 Dec 2020 05:35:06 +0100 Subject: [PATCH] Add newlines and strict types check. --- app/Api/V1/Controllers/Insight/Expense/DateController.php | 3 ++- app/Api/V1/Controllers/Insight/Income/DateController.php | 3 ++- app/Api/V1/Controllers/Webhook/CreateController.php | 3 ++- app/Api/V1/Controllers/Webhook/DeleteController.php | 3 ++- app/Api/V1/Controllers/Webhook/EditController.php | 3 ++- app/Api/V1/Controllers/Webhook/IndexController.php | 3 ++- app/Api/V1/Requests/Webhook/CreateRequest.php | 3 ++- app/Api/V1/Requests/Webhook/UpdateRequest.php | 3 ++- app/Console/Commands/Upgrade/AppendBudgetLimitPeriods.php | 1 + app/Events/DestroyedTransactionLink.php | 2 +- app/Events/DetectedNewIPAddress.php | 2 +- app/Events/RequestedSendWebhookMessages.php | 3 ++- app/Events/StoredTransactionLink.php | 2 +- app/Events/UpdatedTransactionLink.php | 2 +- app/Generator/Webhook/MessageGeneratorInterface.php | 3 ++- app/Generator/Webhook/StandardMessageGenerator.php | 3 ++- app/Handlers/Events/DestroyedGroupEventHandler.php | 3 ++- app/Handlers/Events/WebhookEventHandler.php | 3 ++- app/Helpers/Webhook/Sha3SignatureGenerator.php | 3 ++- app/Helpers/Webhook/SignatureGeneratorInterface.php | 3 ++- app/Jobs/SendWebhookMessage.php | 1 + app/Mail/NewIPAddressWarningMail.php | 2 +- app/Models/Note.php | 2 +- app/Models/Webhook.php | 3 ++- app/Models/WebhookAttempt.php | 3 ++- app/Models/WebhookMessage.php | 3 ++- app/Repositories/Webhook/WebhookRepository.php | 3 ++- app/Repositories/Webhook/WebhookRepositoryInterface.php | 3 ++- app/Rules/IsDuplicateTransaction.php | 3 ++- app/Services/Webhook/StandardWebhookSender.php | 3 ++- app/Services/Webhook/WebhookSenderInterface.php | 3 ++- app/Support/Chart/Budget/FrontpageChartGenerator.php | 2 +- app/Support/Report/Category/CategoryReportGenerator.php | 3 ++- app/Support/Request/ChecksLogin.php | 2 +- app/Support/Request/GetRuleConfiguration.php | 2 +- app/Support/Search/OperatorQuerySearch.php | 2 +- app/TransactionRules/Engine/RuleEngineInterface.php | 2 +- app/TransactionRules/Engine/SearchRuleEngine.php | 2 +- app/Transformers/WebhookTransformer.php | 3 ++- config/queue.php | 1 + database/migrations/2020_11_12_070604_changes_for_v550.php | 1 + resources/lang/.gitignore | 2 +- .../Correction/CorrectOpeningBalanceCurrenciesTest.php | 3 ++- .../Console/Commands/Correction/FixAccountOrderTest.php | 3 ++- .../Console/Commands/Correction/FixGroupAccountsTest.php | 3 ++- .../Console/Commands/Correction/FixLongDescriptionsTest.php | 3 ++- .../Commands/Correction/FixRecurringTransactionsTest.php | 3 ++- .../Console/Commands/Correction/FixTransactionTypesTest.php | 3 ++- 48 files changed, 79 insertions(+), 44 deletions(-) diff --git a/app/Api/V1/Controllers/Insight/Expense/DateController.php b/app/Api/V1/Controllers/Insight/Expense/DateController.php index 650e674fb9..ee47dd7b14 100644 --- a/app/Api/V1/Controllers/Insight/Expense/DateController.php +++ b/app/Api/V1/Controllers/Insight/Expense/DateController.php @@ -1,4 +1,5 @@ json($tempData); } -} \ No newline at end of file +} diff --git a/app/Api/V1/Controllers/Insight/Income/DateController.php b/app/Api/V1/Controllers/Insight/Income/DateController.php index 5ae5b1eb8a..58cad852d2 100644 --- a/app/Api/V1/Controllers/Insight/Income/DateController.php +++ b/app/Api/V1/Controllers/Insight/Income/DateController.php @@ -1,4 +1,5 @@ json($tempData); } -} \ No newline at end of file +} diff --git a/app/Api/V1/Controllers/Webhook/CreateController.php b/app/Api/V1/Controllers/Webhook/CreateController.php index d6413563fc..3de3ba88a6 100644 --- a/app/Api/V1/Controllers/Webhook/CreateController.php +++ b/app/Api/V1/Controllers/Webhook/CreateController.php @@ -1,4 +1,5 @@ json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE); } -} \ No newline at end of file +} diff --git a/app/Api/V1/Controllers/Webhook/DeleteController.php b/app/Api/V1/Controllers/Webhook/DeleteController.php index 2726b8b365..1edb050995 100644 --- a/app/Api/V1/Controllers/Webhook/DeleteController.php +++ b/app/Api/V1/Controllers/Webhook/DeleteController.php @@ -1,4 +1,5 @@ json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE); } -} \ No newline at end of file +} diff --git a/app/Api/V1/Controllers/Webhook/IndexController.php b/app/Api/V1/Controllers/Webhook/IndexController.php index 30b4a9af0e..ddd98f15de 100644 --- a/app/Api/V1/Controllers/Webhook/IndexController.php +++ b/app/Api/V1/Controllers/Webhook/IndexController.php @@ -1,4 +1,5 @@ json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE); } -} \ No newline at end of file +} diff --git a/app/Api/V1/Requests/Webhook/CreateRequest.php b/app/Api/V1/Requests/Webhook/CreateRequest.php index 5699b7626a..e0284f1667 100644 --- a/app/Api/V1/Requests/Webhook/CreateRequest.php +++ b/app/Api/V1/Requests/Webhook/CreateRequest.php @@ -1,4 +1,5 @@ ['required', 'url', 'starts_with:https://', 'uniqueWebhook'], ]; } -} \ No newline at end of file +} diff --git a/app/Api/V1/Requests/Webhook/UpdateRequest.php b/app/Api/V1/Requests/Webhook/UpdateRequest.php index 280a0da031..26a4a3f52c 100644 --- a/app/Api/V1/Requests/Webhook/UpdateRequest.php +++ b/app/Api/V1/Requests/Webhook/UpdateRequest.php @@ -1,4 +1,5 @@ ['required', 'url', 'starts_with:https://', sprintf('uniqueExistingWebhook:%d', $webhook->id)], ]; } -} \ No newline at end of file +} diff --git a/app/Console/Commands/Upgrade/AppendBudgetLimitPeriods.php b/app/Console/Commands/Upgrade/AppendBudgetLimitPeriods.php index 3e6cb6e520..76375e5677 100644 --- a/app/Console/Commands/Upgrade/AppendBudgetLimitPeriods.php +++ b/app/Console/Commands/Upgrade/AppendBudgetLimitPeriods.php @@ -1,4 +1,5 @@ link = $link; } -} \ No newline at end of file +} diff --git a/app/Events/DetectedNewIPAddress.php b/app/Events/DetectedNewIPAddress.php index 10f07f8345..3e5ecb495b 100644 --- a/app/Events/DetectedNewIPAddress.php +++ b/app/Events/DetectedNewIPAddress.php @@ -47,4 +47,4 @@ class DetectedNewIPAddress extends Event $this->ipAddress = $ipAddress; $this->user = $user; } -} \ No newline at end of file +} diff --git a/app/Events/RequestedSendWebhookMessages.php b/app/Events/RequestedSendWebhookMessages.php index 79dad2d7aa..fd9b132688 100644 --- a/app/Events/RequestedSendWebhookMessages.php +++ b/app/Events/RequestedSendWebhookMessages.php @@ -1,4 +1,5 @@ link = $link; } -} \ No newline at end of file +} diff --git a/app/Events/UpdatedTransactionLink.php b/app/Events/UpdatedTransactionLink.php index 7627560f4d..58a1f1592b 100644 --- a/app/Events/UpdatedTransactionLink.php +++ b/app/Events/UpdatedTransactionLink.php @@ -44,4 +44,4 @@ class UpdatedTransactionLink extends Event { $this->link = $link; } -} \ No newline at end of file +} diff --git a/app/Generator/Webhook/MessageGeneratorInterface.php b/app/Generator/Webhook/MessageGeneratorInterface.php index f41956213a..8487be5833 100644 --- a/app/Generator/Webhook/MessageGeneratorInterface.php +++ b/app/Generator/Webhook/MessageGeneratorInterface.php @@ -1,4 +1,5 @@ version; } -} \ No newline at end of file +} diff --git a/app/Handlers/Events/DestroyedGroupEventHandler.php b/app/Handlers/Events/DestroyedGroupEventHandler.php index 0d9a1c599e..7d5cd667ef 100644 --- a/app/Handlers/Events/DestroyedGroupEventHandler.php +++ b/app/Handlers/Events/DestroyedGroupEventHandler.php @@ -1,4 +1,5 @@ afterResponse(); } } -} \ No newline at end of file +} diff --git a/app/Helpers/Webhook/Sha3SignatureGenerator.php b/app/Helpers/Webhook/Sha3SignatureGenerator.php index 2540f5b21e..78346f9fd1 100644 --- a/app/Helpers/Webhook/Sha3SignatureGenerator.php +++ b/app/Helpers/Webhook/Sha3SignatureGenerator.php @@ -1,4 +1,5 @@ getVersion(), $signature); } -} \ No newline at end of file +} diff --git a/app/Helpers/Webhook/SignatureGeneratorInterface.php b/app/Helpers/Webhook/SignatureGeneratorInterface.php index bee206e11f..e4af7c0e65 100644 --- a/app/Helpers/Webhook/SignatureGeneratorInterface.php +++ b/app/Helpers/Webhook/SignatureGeneratorInterface.php @@ -1,4 +1,5 @@ view('emails.new-ip-html')->text('emails.new-ip-text') ->subject((string) trans('email.login_from_new_ip')); } -} \ No newline at end of file +} diff --git a/app/Models/Note.php b/app/Models/Note.php index 553883f030..f5543f5d11 100644 --- a/app/Models/Note.php +++ b/app/Models/Note.php @@ -87,4 +87,4 @@ class Note extends Model } -} \ No newline at end of file +} diff --git a/app/Models/Webhook.php b/app/Models/Webhook.php index 2ddd8c04ef..3ca961801c 100644 --- a/app/Models/Webhook.php +++ b/app/Models/Webhook.php @@ -1,4 +1,5 @@ hasMany(WebhookMessage::class); } -} \ No newline at end of file +} diff --git a/app/Models/WebhookAttempt.php b/app/Models/WebhookAttempt.php index d95062a8b5..d4523dc0e6 100644 --- a/app/Models/WebhookAttempt.php +++ b/app/Models/WebhookAttempt.php @@ -1,4 +1,5 @@ belongsTo(WebhookMessage::class); } -} \ No newline at end of file +} diff --git a/app/Models/WebhookMessage.php b/app/Models/WebhookMessage.php index 4d6bc7a8cc..0b3704cd21 100644 --- a/app/Models/WebhookMessage.php +++ b/app/Models/WebhookMessage.php @@ -1,4 +1,5 @@ delete(); } -} \ No newline at end of file +} diff --git a/app/Repositories/Webhook/WebhookRepositoryInterface.php b/app/Repositories/Webhook/WebhookRepositoryInterface.php index 70486b7efc..8d6dc5fe46 100644 --- a/app/Repositories/Webhook/WebhookRepositoryInterface.php +++ b/app/Repositories/Webhook/WebhookRepositoryInterface.php @@ -1,4 +1,5 @@ value; } -} \ No newline at end of file +} diff --git a/app/Services/Webhook/StandardWebhookSender.php b/app/Services/Webhook/StandardWebhookSender.php index 69d4b7d7fb..7739c14e7b 100644 --- a/app/Services/Webhook/StandardWebhookSender.php +++ b/app/Services/Webhook/StandardWebhookSender.php @@ -1,4 +1,5 @@ sendMessageV0($this->message); } -} \ No newline at end of file +} diff --git a/app/Services/Webhook/WebhookSenderInterface.php b/app/Services/Webhook/WebhookSenderInterface.php index 10f52eaec1..a5e03c302c 100644 --- a/app/Services/Webhook/WebhookSenderInterface.php +++ b/app/Services/Webhook/WebhookSenderInterface.php @@ -1,4 +1,5 @@ opsRepository->setUser($user); } -} \ No newline at end of file +} diff --git a/app/Support/Request/ChecksLogin.php b/app/Support/Request/ChecksLogin.php index 71222e03a3..0b91c83e6a 100644 --- a/app/Support/Request/ChecksLogin.php +++ b/app/Support/Request/ChecksLogin.php @@ -37,4 +37,4 @@ trait ChecksLogin // Only allow logged in users return auth()->check(); } -} \ No newline at end of file +} diff --git a/app/Support/Request/GetRuleConfiguration.php b/app/Support/Request/GetRuleConfiguration.php index 0eb328194c..8be6823193 100644 --- a/app/Support/Request/GetRuleConfiguration.php +++ b/app/Support/Request/GetRuleConfiguration.php @@ -50,4 +50,4 @@ trait GetRuleConfiguration } return $return; } -} \ No newline at end of file +} diff --git a/app/Support/Search/OperatorQuerySearch.php b/app/Support/Search/OperatorQuerySearch.php index 3286ac3926..0a9b52af1a 100644 --- a/app/Support/Search/OperatorQuerySearch.php +++ b/app/Support/Search/OperatorQuerySearch.php @@ -832,4 +832,4 @@ class OperatorQuerySearch implements SearchInterface { return $this->accountRepository->getCashAccount(); } -} \ No newline at end of file +} diff --git a/app/TransactionRules/Engine/RuleEngineInterface.php b/app/TransactionRules/Engine/RuleEngineInterface.php index bd5b5f18da..f976038593 100644 --- a/app/TransactionRules/Engine/RuleEngineInterface.php +++ b/app/TransactionRules/Engine/RuleEngineInterface.php @@ -65,4 +65,4 @@ interface RuleEngineInterface */ public function find(): Collection; -} \ No newline at end of file +} diff --git a/app/TransactionRules/Engine/SearchRuleEngine.php b/app/TransactionRules/Engine/SearchRuleEngine.php index bffd7a1d82..e876aa16e7 100644 --- a/app/TransactionRules/Engine/SearchRuleEngine.php +++ b/app/TransactionRules/Engine/SearchRuleEngine.php @@ -424,4 +424,4 @@ class SearchRuleEngine implements RuleEngineInterface return $all; } -} \ No newline at end of file +} diff --git a/app/Transformers/WebhookTransformer.php b/app/Transformers/WebhookTransformer.php index 8626f85d85..ea99a44380 100644 --- a/app/Transformers/WebhookTransformer.php +++ b/app/Transformers/WebhookTransformer.php @@ -1,4 +1,5 @@ enums[$value] ?? 'UNKNOWN_VALUE'; } -} \ No newline at end of file +} diff --git a/config/queue.php b/config/queue.php index a8bf551583..d6637fd655 100644 --- a/config/queue.php +++ b/config/queue.php @@ -1,4 +1,5 @@ forceDelete(); } -} \ No newline at end of file +} diff --git a/tests/Feature/Console/Commands/Correction/FixAccountOrderTest.php b/tests/Feature/Console/Commands/Correction/FixAccountOrderTest.php index 805f01ea0f..a2a45f152d 100644 --- a/tests/Feature/Console/Commands/Correction/FixAccountOrderTest.php +++ b/tests/Feature/Console/Commands/Correction/FixAccountOrderTest.php @@ -1,4 +1,5 @@ save(); } -} \ No newline at end of file +} diff --git a/tests/Feature/Console/Commands/Correction/FixRecurringTransactionsTest.php b/tests/Feature/Console/Commands/Correction/FixRecurringTransactionsTest.php index e1d296dfbd..e4b7dcd12f 100644 --- a/tests/Feature/Console/Commands/Correction/FixRecurringTransactionsTest.php +++ b/tests/Feature/Console/Commands/Correction/FixRecurringTransactionsTest.php @@ -1,4 +1,5 @@ assertExitCode(0); } -} \ No newline at end of file +} diff --git a/tests/Feature/Console/Commands/Correction/FixTransactionTypesTest.php b/tests/Feature/Console/Commands/Correction/FixTransactionTypesTest.php index 3b6877cd7d..15a552381e 100644 --- a/tests/Feature/Console/Commands/Correction/FixTransactionTypesTest.php +++ b/tests/Feature/Console/Commands/Correction/FixTransactionTypesTest.php @@ -1,4 +1,5 @@