kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-16 17:33:45 +00:00
Code Issues Projects Releases Wiki Activity

Clean up API routes

Browse Source
This commit is contained in:
James Cole
2024-10-20 17:55:06 +02:00
parent 6ff84b8e90
commit acadc89eaa
5 changed files with 69 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/Support/Http/Api/CollectsAccountsFromFilter.php
View File

@@ -36,10 +36,12 @@ trait CollectsAccountsFromFilter
$collection = new Collection();
// always collect from the query parameter, even when it's empty.
foreach ($queryParameters['accounts'] as $accountId) {
$account = $this->repository->find((int) $accountId);
if (null !== $account) {
$collection->push($account);
if (null !== $queryParameters['accounts']) {
foreach ($queryParameters['accounts'] as $accountId) {
$account = $this->repository->find((int) $accountId);
if (null !== $account) {
$collection->push($account);
}
}
}

4
app/Support/Request/ConvertsDataTypes.php
View File

@@ -105,11 +105,11 @@ trait ConvertsDataTypes
/**
* Return string value.
*/
public function convertString(string $field): string
public function convertString(string $field, string $default = ''): string
{
$entry = $this->get($field);
if (!is_scalar($entry)) {
return '';
return $default;
}
return (string)$this->clearString((string)$entry);