Refactor basic methods to trait

This commit is contained in:
James Cole
2018-08-09 16:16:27 +02:00
parent 0c2093753d
commit aa0758cd2b
3 changed files with 71 additions and 33 deletions

View File

@@ -27,6 +27,7 @@ use FireflyIII\Generator\Chart\Basic\GeneratorInterface;
use FireflyIII\Http\Controllers\Controller;
use FireflyIII\Repositories\Account\AccountTaskerInterface;
use FireflyIII\Support\CacheProperties;
use FireflyIII\Support\Http\Controllers\BasicDataSupport;
use Illuminate\Http\JsonResponse;
use Illuminate\Support\Collection;
use Log;
@@ -36,6 +37,7 @@ use Log;
*/
class ReportController extends Controller
{
use BasicDataSupport;
/** @var GeneratorInterface Chart generation methods. */
protected $generator;
@@ -219,23 +221,6 @@ class ReportController extends Controller
return response()->json($data);
}
/**
* Sum up an array.
*
* @param array $array
*
* @return string
*/
protected function arraySum(array $array): string // filter + group data
{
$sum = '0';
foreach ($array as $entry) {
$sum = bcadd($sum, $entry);
}
return $sum;
}
/**
* Collects the incomes and expenses for the given periods, grouped per month. Will cache its results.
*