kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-15 16:57:09 +00:00
Code Issues Projects Releases Wiki Activity

Code cleanup

Browse Source
This commit is contained in:
James Cole
2018-04-02 15:10:40 +02:00
parent fa7ab45a40
commit a3c34e6b3c
151 changed files with 802 additions and 990 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/Models/Transaction.php
View File

@@ -27,7 +27,6 @@ use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Watson\Validating\ValidatingTrait;
/**
* Class Transaction.
@@ -98,17 +97,6 @@ class Transaction extends Model
* @var array
*/
protected $hidden = ['encrypted'];
/**
* @var array
*/
protected $rules
= [
'account_id' => 'required|exists:accounts,id',
'transaction_journal_id' => 'required|exists:transaction_journals,id',
'transaction_currency_id' => 'required|exists:transaction_currencies,id',
'description' => 'between:0,1024',
'amount' => 'required|numeric',
];
/**
* @codeCoverageIgnore
@@ -142,10 +130,10 @@ class Transaction extends Model
public static function routeBinder(string $value): Transaction
{
if (auth()->check()) {
$transactionId = intval($value);
$transactionId = (int)$value;
$transaction = auth()->user()->transactions()->where('transactions.id', $transactionId)
->first(['transactions.*']);
if (!is_null($transaction)) {
if (null !== $transaction) {
return $transaction;
}
}
@@ -153,7 +141,7 @@ class Transaction extends Model
throw new NotFoundHttpException;
}
use SoftDeletes, ValidatingTrait;
use SoftDeletes;
/**
* @codeCoverageIgnore
@@ -256,7 +244,7 @@ class Transaction extends Model
*/
public function setAmountAttribute($value)
{
$this->attributes['amount'] = strval($value);
$this->attributes['amount'] = (string)$value;
}
/**