kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-18 02:03:40 +00:00
Code Issues Projects Releases Wiki Activity

Fix return type #2440

Browse Source
This commit is contained in:
James Cole
2019-08-22 17:09:08 +02:00
parent 2a4051fe92
commit a11f876c49
1 changed files with 31 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
app/Repositories/Recurring/RecurringRepository.php
View File

@@ -209,24 +209,6 @@ class RecurringRepository implements RecurringRepositoryInterface
return ''; return '';
} }
/**
* @param Recurrence $recurrence
* @return PiggyBank|null
*/
public function getPiggyBank(Recurrence $recurrence): ?PiggyBank
{
$meta = $recurrence->recurrenceMeta;
/** @var RecurrenceMeta $metaEntry */
foreach ($meta as $metaEntry) {
if ('piggy_bank_id' === $metaEntry->name) {
$piggyId = (int)$metaEntry->value;
return $this->user->piggyBanks()->where('piggy_banks.id', $piggyId)->first(['piggy_banks.*']);
}
}
return null;
}
/** /**
* Generate events in the date range. * Generate events in the date range.
* *
@@ -269,6 +251,26 @@ class RecurringRepository implements RecurringRepositoryInterface
return $occurrences; return $occurrences;
} }
/**
* @param Recurrence $recurrence
*
* @return PiggyBank|null
*/
public function getPiggyBank(Recurrence $recurrence): ?PiggyBank
{
$meta = $recurrence->recurrenceMeta;
/** @var RecurrenceMeta $metaEntry */
foreach ($meta as $metaEntry) {
if ('piggy_bank_id' === $metaEntry->name) {
$piggyId = (int)$metaEntry->value;
return $this->user->piggyBanks()->where('piggy_banks.id', $piggyId)->first(['piggy_banks.*']);
}
}
return null;
}
/** /**
* Get the tags from the recurring transaction. * Get the tags from the recurring transaction.
* *
@@ -336,14 +338,12 @@ class RecurringRepository implements RecurringRepositoryInterface
->get()->pluck('transaction_journal_id')->toArray(); ->get()->pluck('transaction_journal_id')->toArray();
$search = []; $search = [];
foreach ($journalMeta as $journalId) { foreach ($journalMeta as $journalId) {
$search[] = (int)$journalId; $search[] = (int)$journalId;
} }
if (0 === count($search)) { if (0 === count($search)) {
return []; return new Collection;
} }
/** @var GroupCollectorInterface $collector */ /** @var GroupCollectorInterface $collector */