kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-16 17:33:45 +00:00
Code Issues Projects Releases Wiki Activity

Implement rule group and rule tests

Browse Source
This commit is contained in:
James Cole
2019-06-09 09:40:08 +02:00
parent a1929b0521
commit 9d0a5c97c2
2 changed files with 57 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
tests/Api/V1/Controllers/RuleControllerTest.php
View File

@@ -33,8 +33,6 @@ use FireflyIII\Repositories\Rule\RuleRepositoryInterface;
use FireflyIII\TransactionRules\TransactionMatcher; use FireflyIII\TransactionRules\TransactionMatcher;
use FireflyIII\Transformers\RuleTransformer; use FireflyIII\Transformers\RuleTransformer;
use FireflyIII\Transformers\TransactionGroupTransformer; use FireflyIII\Transformers\TransactionGroupTransformer;
use FireflyIII\Transformers\TransactionTransformer;
use Illuminate\Support\Collection;
use Laravel\Passport\Passport; use Laravel\Passport\Passport;
use Log; use Log;
use Queue; use Queue;
@@ -45,6 +43,7 @@ use Tests\TestCase;
* Class RuleControllerTest * Class RuleControllerTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects) * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength) * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/ */
class RuleControllerTest extends TestCase class RuleControllerTest extends TestCase
{ {
@@ -131,7 +130,7 @@ class RuleControllerTest extends TestCase
'active' => 1, 'active' => 1,
'triggers' => [ 'triggers' => [
[ [
'name' => 'description_is', 'type' => 'description_is',
'value' => 'Hello', 'value' => 'Hello',
'stop_processing' => 1, 'stop_processing' => 1,
], ],
@@ -143,6 +142,15 @@ class RuleControllerTest extends TestCase
// test API // test API
$response = $this->post(route('api.v1.rules.store'), $data, ['Accept' => 'application/json']); $response = $this->post(route('api.v1.rules.store'), $data, ['Accept' => 'application/json']);
$response->assertStatus(422); $response->assertStatus(422);
$response->assertExactJson(
[
'errors' => [
'title' => [
'Rule must have at least one action.',
],
],
'message' => 'The given data was invalid.',
]);
} }
/** /**
@@ -168,7 +176,7 @@ class RuleControllerTest extends TestCase
], ],
'actions' => [ 'actions' => [
[ [
'name' => 'add_tag', 'type' => 'add_tag',
'value' => 'A', 'value' => 'A',
'stop_processing' => 1, 'stop_processing' => 1,
], ],
@@ -178,7 +186,15 @@ class RuleControllerTest extends TestCase
// test API // test API
$response = $this->post(route('api.v1.rules.store'), $data, ['Accept' => 'application/json']); $response = $this->post(route('api.v1.rules.store'), $data, ['Accept' => 'application/json']);
$response->assertStatus(422); $response->assertStatus(422);
$response->assertSee(''); $response->assertExactJson(
[
'errors' => [
'title' => [
'Rule must have at least one trigger.',
],
],
'message' => 'The given data was invalid.',
]);
} }
@@ -221,8 +237,6 @@ class RuleControllerTest extends TestCase
$transformer->shouldReceive('transform')->atLeast()->once()->andReturn(['id' => 5]); $transformer->shouldReceive('transform')->atLeast()->once()->andReturn(['id' => 5]);
$response = $this->get(route('api.v1.rules.test', [$rule->id]) . '?accounts=1,2,3'); $response = $this->get(route('api.v1.rules.test', [$rule->id]) . '?accounts=1,2,3');
$response->assertStatus(200); $response->assertStatus(200);
} }
@@ -232,28 +246,21 @@ class RuleControllerTest extends TestCase
*/ */
public function testTriggerRule(): void public function testTriggerRule(): void
{ {
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
return;
$rule = $this->user()->rules()->first(); $rule = $this->user()->rules()->first();
$repository = $this->mock(AccountRepositoryInterface::class); $repository = $this->mock(AccountRepositoryInterface::class);
$matcher = $this->mock(TransactionMatcher::class);
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$ruleRepos = $this->mock(RuleRepositoryInterface::class); $ruleRepos = $this->mock(RuleRepositoryInterface::class);
$transformer = $this->mock(RuleTransformer::class);
$asset = $this->getRandomAsset(); $asset = $this->getRandomAsset();
$expense = $this->getRandomExpense();
$repository->shouldReceive('setUser')->once(); $repository->shouldReceive('setUser')->once();
$ruleRepos->shouldReceive('setUser')->once(); $ruleRepos->shouldReceive('setUser')->once();
$repository->shouldReceive('findNull')->withArgs([1])->andReturn($asset); $repository->shouldReceive('findNull')->withArgs([1])->andReturn($asset);
$repository->shouldReceive('findNull')->withArgs([2])->andReturn($asset); $repository->shouldReceive('findNull')->withArgs([2])->andReturn($expense);
$repository->shouldReceive('findNull')->withArgs([3])->andReturn(null); $repository->shouldReceive('findNull')->withArgs([3])->andReturn(null);
$repository->shouldReceive('isAsset')->andReturn(true, false);
Queue::fake(); Queue::fake();
$response = $this->post(route('api.v1.rules.trigger', [$rule->id]) . '?accounts=1,2,3&start_date=2019-01-01&end_date=2019-01-02');
$response = $this->post(route('api.v1.rules.trigger', [$rule->id]) . '?accounts=1,2,3');
$response->assertStatus(204); $response->assertStatus(204);
Queue::assertPushed( Queue::assertPushed(
@@ -269,9 +276,6 @@ class RuleControllerTest extends TestCase
*/ */
public function testUpdate(): void public function testUpdate(): void
{ {
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
return;
$ruleRepos = $this->mock(RuleRepositoryInterface::class); $ruleRepos = $this->mock(RuleRepositoryInterface::class);
$accountRepos = $this->mock(AccountRepositoryInterface::class); $accountRepos = $this->mock(AccountRepositoryInterface::class);
$transformer = $this->mock(RuleTransformer::class); $transformer = $this->mock(RuleTransformer::class);
@@ -285,6 +289,7 @@ class RuleControllerTest extends TestCase
$accountRepos->shouldReceive('setUser')->once(); $accountRepos->shouldReceive('setUser')->once();
$ruleRepos->shouldReceive('setUser')->once(); $ruleRepos->shouldReceive('setUser')->once();
/** @var Rule $rule */ /** @var Rule $rule */
$rule = $this->user()->rules()->first(); $rule = $this->user()->rules()->first();
$data = [ $data = [

51
tests/Api/V1/Controllers/RuleGroupControllerTest.php
View File

@@ -26,14 +26,12 @@ namespace Tests\Api\V1\Controllers;
use FireflyIII\Jobs\ExecuteRuleOnExistingTransactions; use FireflyIII\Jobs\ExecuteRuleOnExistingTransactions;
use FireflyIII\Jobs\Job; use FireflyIII\Jobs\Job;
use FireflyIII\Models\RuleGroup;
use FireflyIII\Repositories\Account\AccountRepositoryInterface; use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface; use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use FireflyIII\Repositories\RuleGroup\RuleGroupRepositoryInterface; use FireflyIII\Repositories\RuleGroup\RuleGroupRepositoryInterface;
use FireflyIII\TransactionRules\TransactionMatcher; use FireflyIII\TransactionRules\TransactionMatcher;
use FireflyIII\Transformers\RuleGroupTransformer; use FireflyIII\Transformers\RuleGroupTransformer;
use FireflyIII\Transformers\RuleTransformer; use FireflyIII\Transformers\TransactionGroupTransformer;
use FireflyIII\Transformers\TransactionTransformer;
use Illuminate\Support\Collection; use Illuminate\Support\Collection;
use Laravel\Passport\Passport; use Laravel\Passport\Passport;
use Log; use Log;
@@ -43,6 +41,9 @@ use Tests\TestCase;
/** /**
* *
* Class RuleGroupControllerTest * Class RuleGroupControllerTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/ */
class RuleGroupControllerTest extends TestCase class RuleGroupControllerTest extends TestCase
{ {
@@ -78,7 +79,7 @@ class RuleGroupControllerTest extends TestCase
$ruleGroupRepos->shouldReceive('setUser')->once(); $ruleGroupRepos->shouldReceive('setUser')->once();
$ruleGroup = $this->user()->ruleGroups()->first(); $ruleGroup = $this->user()->ruleGroups()->first();
$data = [ $data = [
'title' => 'Store new rule ' . random_int(1, 100000), 'title' => 'Store new rule group ' . random_int(1, 100000),
'active' => 1, 'active' => 1,
'description' => 'Hello', 'description' => 'Hello',
]; ];
@@ -86,7 +87,7 @@ class RuleGroupControllerTest extends TestCase
$ruleGroupRepos->shouldReceive('store')->once()->andReturn($ruleGroup); $ruleGroupRepos->shouldReceive('store')->once()->andReturn($ruleGroup);
// test API // test API
$response = $this->post('/api/v1/rule_groups', $data, ['Accept' => 'application/json']); $response = $this->post(route('api.v1.rule_groups.store'), $data, ['Accept' => 'application/json']);
$response->assertStatus(200); $response->assertStatus(200);
} }
@@ -96,40 +97,37 @@ class RuleGroupControllerTest extends TestCase
*/ */
public function testTestGroupBasic(): void public function testTestGroupBasic(): void
{ {
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
return;
$group = $this->user()->ruleGroups()->first(); $group = $this->user()->ruleGroups()->first();
$rule = $this->user()->rules()->first(); $rule = $this->user()->rules()->first();
$ruleGroupRepos = $this->mock(RuleGroupRepositoryInterface::class); $ruleGroupRepos = $this->mock(RuleGroupRepositoryInterface::class);
$repository = $this->mock(AccountRepositoryInterface::class); $repository = $this->mock(AccountRepositoryInterface::class);
$matcher = $this->mock(TransactionMatcher::class); $matcher = $this->mock(TransactionMatcher::class);
$journalRepos = $this->mock(JournalRepositoryInterface::class); $transformer = $this->mock(TransactionGroupTransformer::class);
$transformer = $this->mock(TransactionTransformer::class);
// mock calls
$asset = $this->getRandomAsset();
$expense = $this->getRandomExpense();
// mock transformer
$transformer->shouldReceive('setParameters')->withAnyArgs()->atLeast()->once();
$ruleGroupRepos->shouldReceive('setUser')->once(); $ruleGroupRepos->shouldReceive('setUser')->once();
$ruleGroupRepos->shouldReceive('getActiveRules')->once()->andReturn(new Collection([$rule]));
$asset = $this->getRandomAsset();
$repository->shouldReceive('setUser')->once(); $repository->shouldReceive('setUser')->once();
$repository->shouldReceive('findNull')->withArgs([1])->andReturn($asset); $ruleGroupRepos->shouldReceive('getActiveRules')->once()->andReturn(new Collection([$rule]));
$repository->shouldReceive('findNull')->withArgs([2])->andReturn($asset);
$repository->shouldReceive('findNull')->withArgs([3])->andReturn(null);
$repository->shouldReceive('isAsset')->withArgs([1])->andReturn(true);
$repository->shouldReceive('isAsset')->withArgs([2])->andReturn(false);
$repository->shouldReceive('findNull')->withArgs([1])->andReturn($asset);
$repository->shouldReceive('findNull')->withArgs([2])->andReturn($expense);
$repository->shouldReceive('findNull')->withArgs([3])->andReturn(null);
$transformer->shouldReceive('setParameters')->withAnyArgs()->atLeast()->once();
$matcher->shouldReceive('setRule')->once(); $matcher->shouldReceive('setRule')->once();
$matcher->shouldReceive('setEndDate')->once(); $matcher->shouldReceive('setEndDate')->once();
$matcher->shouldReceive('setStartDate')->once(); $matcher->shouldReceive('setStartDate')->once();
$matcher->shouldReceive('setSearchLimit')->once(); $matcher->shouldReceive('setSearchLimit')->once();
$matcher->shouldReceive('setTriggeredLimit')->once(); $matcher->shouldReceive('setTriggeredLimit')->once();
$matcher->shouldReceive('setAccounts')->once(); $matcher->shouldReceive('setAccounts')->once();
$matcher->shouldReceive('findTransactionsByRule')->once()->andReturn(new Collection); $matcher->shouldReceive('findTransactionsByRule')->once()->andReturn([]);
// call API // call API
$response = $this->get(route('api.v1.rule_groups.test', [$group->id]) . '?accounts=1,2,3'); $response = $this->get(route('api.v1.rule_groups.test', [$group->id]) . '?accounts=1,2,3');
@@ -141,10 +139,8 @@ class RuleGroupControllerTest extends TestCase
*/ */
public function testTestGroupEmpty(): void public function testTestGroupEmpty(): void
{ {
$ruleGroupRepos = $this->mock(RuleGroupRepositoryInterface::class); $ruleGroupRepos = $this->mock(RuleGroupRepositoryInterface::class);
$accountRepos = $this->mock(AccountRepositoryInterface::class); $accountRepos = $this->mock(AccountRepositoryInterface::class);
$transformer = $this->mock(RuleGroupTransformer::class);
$accountRepos->shouldReceive('setUser')->once(); $accountRepos->shouldReceive('setUser')->once();
$ruleGroupRepos->shouldReceive('setUser')->once(); $ruleGroupRepos->shouldReceive('setUser')->once();
@@ -152,8 +148,9 @@ class RuleGroupControllerTest extends TestCase
// call API // call API
$group = $this->user()->ruleGroups()->first(); $group = $this->user()->ruleGroups()->first();
$response = $this->get(route('api.v1.rule_groups.test', [$group->id])); $response = $this->get(route('api.v1.rule_groups.test', [$group->id]), ['Accept' => 'application/json']);
$response->assertStatus(500); $response->assertStatus(500);
$response->assertSee('{"message":"No rules in this rule group.","exception":"FireflyIII\\\\Exceptions\\\\FireflyException"');
} }
/** /**
@@ -164,7 +161,7 @@ class RuleGroupControllerTest extends TestCase
$group = $this->user()->ruleGroups()->first(); $group = $this->user()->ruleGroups()->first();
$rule = $this->user()->rules()->first(); $rule = $this->user()->rules()->first();
$asset = $this->getRandomAsset(); $asset = $this->getRandomAsset();
$expense = $this->getRandomExpense();
$ruleGroupRepos = $this->mock(RuleGroupRepositoryInterface::class); $ruleGroupRepos = $this->mock(RuleGroupRepositoryInterface::class);
$repository = $this->mock(AccountRepositoryInterface::class); $repository = $this->mock(AccountRepositoryInterface::class);
@@ -175,13 +172,13 @@ class RuleGroupControllerTest extends TestCase
$ruleGroupRepos->shouldReceive('getActiveRules')->once()->andReturn(new Collection([$rule])); $ruleGroupRepos->shouldReceive('getActiveRules')->once()->andReturn(new Collection([$rule]));
$repository->shouldReceive('findNull')->withArgs([1])->andReturn($asset); $repository->shouldReceive('findNull')->withArgs([1])->andReturn($asset);
$repository->shouldReceive('findNull')->withArgs([2])->andReturn($asset); $repository->shouldReceive('findNull')->withArgs([2])->andReturn($expense);
$repository->shouldReceive('findNull')->withArgs([3])->andReturn(null); $repository->shouldReceive('findNull')->withArgs([3])->andReturn(null);
$repository->shouldReceive('isAsset')->withArgs([1])->andReturn(true); $repository->shouldReceive('isAsset')->withArgs([1])->andReturn(true);
$repository->shouldReceive('isAsset')->withArgs([2])->andReturn(false); $repository->shouldReceive('isAsset')->withArgs([2])->andReturn(false);
Queue::fake(); Queue::fake();
$response = $this->post(route('api.v1.rule_groups.trigger', [$group->id]) . '?accounts=1,2,3'); $response = $this->post(route('api.v1.rule_groups.trigger', [$group->id]) . '?accounts=1,2,3&start_date=2019-01-01&end_date=2019-01-02');
$response->assertStatus(204); $response->assertStatus(204);