Code cleanup.

app/Export/Exporter/CsvExporter.php

@@ -14,7 +14,6 @@ declare(strict_types = 1);
 namespace FireflyIII\Export\Exporter;
 
 use FireflyIII\Export\Entry\Entry;
-use FireflyIII\Export\Entry\EntryAccount;
 use FireflyIII\Models\ExportJob;
 use League\Csv\Writer;
 use SplFileObject;

app/Export/Processor.php

@@ -45,8 +45,6 @@ class Processor
     public $job;
     /** @var array */
     public $settings;
-    /** @var  \FireflyIII\Export\ConfigurationFile */
-    private $configurationMaker;
     /** @var  Collection */
     private $exportEntries;
     /** @var  Collection */

app/Helpers/Attachments/AttachmentHelper.php

@@ -17,10 +17,8 @@ use FireflyIII\Models\Attachment;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\MessageBag;
 use Input;
-use Log;
 use Storage;
 use Symfony\Component\HttpFoundation\File\UploadedFile;
-use TypeError;
 
 /**
  * Class AttachmentHelper
@@ -236,14 +234,9 @@ class AttachmentHelper implements AttachmentHelperInterface
     private function getFiles()
     {
         $files = null;
-        try {
         if (Input::hasFile('attachments')) {
             $files = Input::file('attachments');
         }
-        } catch (TypeError $e) {
-            // Log it, do nothing else.
-            Log::error($e->getMessage());
-        }
 
         return $files;
     }

app/Helpers/Collector/JournalCollector.php

@@ -57,19 +57,6 @@ class JournalCollector
         ];
     /** @var  bool */
     private $filterTransfers = false;
-    /** @var array */
-    private $group
-        = [
-            'transaction_journals.id',
-            'transaction_journals.description',
-            'firefly-iii.transaction_journals.date',
-            'transaction_journals.encrypted',
-            'transaction_currencies.code',
-            'transaction_types.type',
-            'transaction_journals.bill_id',
-            'bills.name',
-            'transactions.amount',
-        ];
     /** @var  bool */
     private $joinedBudget = false;
     /** @var  bool */
@@ -285,6 +272,8 @@ class JournalCollector
     public function setOffset(int $offset): JournalCollector
     {
         $this->offset = $offset;
+
+        return $this;
     }
 
     /**

app/Http/Controllers/AccountController.php

@@ -275,13 +275,12 @@ class AccountController extends Controller
     }
 
     /**
-     * @param AccountTaskerInterface $tasker
      * @param Account                $account
      * @param string                 $date
      *
      * @return View
      */
-    public function showWithDate(AccountTaskerInterface $tasker, Account $account, string $date)
+    public function showWithDate(Account $account, string $date)
     {
         $carbon   = new Carbon($date);
         $range    = Preferences::get('viewRange', '1M')->data;

app/Http/Controllers/BudgetController.php

@@ -24,7 +24,6 @@ use FireflyIII\Models\Budget;
 use FireflyIII\Models\LimitRepetition;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
-use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Support\Collection;
 use Input;
 use Log;

app/Http/Controllers/CategoryController.php

@@ -240,9 +240,7 @@ class CategoryController extends Controller
     }
 
     /**
-     * @param CRI                               $repository
      * @param Category $category
-     *
      * @param          $date
      *
      * @return View

app/Http/Controllers/HomeController.php

@@ -117,7 +117,7 @@ class HomeController extends Controller
     /**
      * @param ARI $repository
      *
-     * @return \Illuminate\Contracts\View\Factory|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector|\Illuminate\View\View
+     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector|View
      */
     public function index(ARI $repository)
     {

app/Http/Controllers/ProfileController.php

@@ -13,7 +13,6 @@ declare(strict_types = 1);
 
 namespace FireflyIII\Http\Controllers;
 
-use FireflyIII\Events\DeletedUser;
 use FireflyIII\Http\Requests\DeleteAccountFormRequest;
 use FireflyIII\Http\Requests\ProfileFormRequest;
 use FireflyIII\User;

app/Http/Controllers/Report/BudgetController.php

@@ -33,6 +33,8 @@ class BudgetController extends Controller
      * @param Carbon                      $start
      * @param Carbon                      $end
      * @param Collection                  $accounts
+     *
+     * @return mixed|string
      */
     public function budgetMultiYear(BudgetReportHelperInterface $helper, Carbon $start, Carbon $end, Collection $accounts)
     {

app/Http/Controllers/Transaction/ConvertController.php

@@ -206,7 +206,6 @@ class ConvertController extends Controller
         $sourceAccount      = TransactionJournal::sourceAccountList($journal)->first();
         $destinationAccount = TransactionJournal::destinationAccountList($journal)->first();
         $sourceType         = $journal->transactionType;
-        $source             = new Account;
         $joined             = $sourceType->type . '-' . $destinationType->type;
         switch ($joined) {
             default:

app/Models/Note.php

@@ -46,8 +46,6 @@ class Note extends Model
 
 
     /**
-     * @param $value
-     *
      * @return string
      */
     public function getMarkdownAttribute(): string

app/Repositories/Budget/BudgetRepository.php

@@ -24,7 +24,6 @@ use FireflyIII\Models\TransactionJournal;
 use FireflyIII\Models\TransactionType;
 use FireflyIII\User;
 use Illuminate\Database\Eloquent\Builder;
-use Illuminate\Database\Eloquent\Relations\HasMany;
 use Illuminate\Database\Query\JoinClause;
 use Illuminate\Support\Collection;
 use Log;

app/Repositories/Journal/JournalRepositoryInterface.php

@@ -29,7 +29,8 @@ interface JournalRepositoryInterface
     /**
      * @param TransactionJournal $journal
      * @param TransactionType    $type
-     * @param array              $data
+     * @param Account            $source
+     * @param Account            $destination
      *
      * @return MessageBag
      */

app/Rules/Actions/ClearCategory.php

@@ -16,6 +16,7 @@ namespace FireflyIII\Rules\Actions;
 
 use FireflyIII\Models\RuleAction;
 use FireflyIII\Models\TransactionJournal;
+use Log;
 
 /**
  * Class ClearCategory