kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-17 01:42:19 +00:00
Code Issues Projects Releases Wiki Activity

New tests.

Browse Source
This commit is contained in:
James Cole
2015-06-28 10:03:34 +02:00
parent c15c45f765
commit 83ec60254c
7 changed files with 26 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Controllers/Chart/AccountController.php
View File

@@ -25,7 +25,7 @@ class AccountController extends Controller
protected $generator; protected $generator;
/** /**
* * @codeCoverageIgnore
*/ */
public function __construct() public function __construct()
{ {

2
app/Http/Controllers/Chart/BillController.php
View File

@@ -26,7 +26,7 @@ class BillController extends Controller
protected $generator; protected $generator;
/** /**
* * @codeCoverageIgnore
*/ */
public function __construct() public function __construct()
{ {

2
app/Http/Controllers/Chart/BudgetController.php
View File

@@ -27,7 +27,7 @@ class BudgetController extends Controller
protected $generator; protected $generator;
/** /**
* * @codeCoverageIgnore
*/ */
public function __construct() public function __construct()
{ {

2
app/Http/Controllers/Chart/CategoryController.php
View File

@@ -26,7 +26,7 @@ class CategoryController extends Controller
protected $generator; protected $generator;
/** /**
* * @codeCoverageIgnore
*/ */
public function __construct() public function __construct()
{ {

2
app/Http/Controllers/Chart/PiggyBankController.php
View File

@@ -23,7 +23,7 @@ class PiggyBankController extends Controller
protected $generator; protected $generator;
/** /**
* * @codeCoverageIgnore
*/ */
public function __construct() public function __construct()
{ {

2
app/Http/Controllers/Chart/ReportController.php
View File

@@ -23,7 +23,7 @@ class ReportController extends Controller
protected $generator; protected $generator;
/** /**
* * @codeCoverageIgnore
*/ */
public function __construct() public function __construct()
{ {

83
tests/helpers/ConnectJournalToPiggyBankTest.php
View File

@@ -88,28 +88,22 @@ class ConnectJournalToPiggyBankTest extends TestCase
} }
/** /**
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @covers FireflyIII\Handlers\Events\ConnectJournalToPiggyBank::handle * @covers FireflyIII\Handlers\Events\ConnectJournalToPiggyBank::handle
*/ */
public function testWithRepetition() public function testWithRepetition()
{ {
FactoryMuffin::create('FireflyIII\Models\TransactionType');
FactoryMuffin::create('FireflyIII\Models\TransactionType');
$user = FactoryMuffin::create('FireflyIII\User'); $user = FactoryMuffin::create('FireflyIII\User');
$this->be($user); $this->be($user);
FactoryMuffin::create('FireflyIII\Models\TransactionType'); // withdrawal
FactoryMuffin::create('FireflyIII\Models\TransactionType'); // deposit
$journal = FactoryMuffin::create('FireflyIII\Models\TransactionJournal'); $journal = FactoryMuffin::create('FireflyIII\Models\TransactionJournal');
$piggyBank = FactoryMuffin::create('FireflyIII\Models\PiggyBank'); $piggyBank = FactoryMuffin::create('FireflyIII\Models\PiggyBank');
$account1 = FactoryMuffin::create('FireflyIII\Models\Account');
$account2 = FactoryMuffin::create('FireflyIII\Models\Account');
$account1->user_id = $user->id;
$account2->user_id = $user->id;
$piggyBank->account_id = $account1->id;
$account1->save();
$account2->save();
$piggyBank->save();
$journal->user_id = $user->id;
$journal->save();
// create piggy bank event to continue handler:
$start = clone $journal->date; $start = clone $journal->date;
$end = clone $journal->date; $end = clone $journal->date;
$start->subDay(); $start->subDay();
@@ -124,59 +118,22 @@ class ConnectJournalToPiggyBankTest extends TestCase
] ]
); );
/** @var Transaction $transaction */
foreach ($journal->transactions()->get() as $transaction) {
if ($transaction->amount < 0) {
$piggyBank->account_id = $transaction->account_id;
$account = $transaction->account;
$account->user_id = $user->id;
$account->save();
$piggyBank->account_id = $account->id;
$piggyBank->save();
}
}
$event = new JournalCreated($journal, $piggyBank->id); $event = new JournalCreated($journal, $piggyBank->id);
$class = new ConnectJournalToPiggyBank(); $class = new ConnectJournalToPiggyBank();
$result = $class->handle($event); $result = $class->handle($event);
$this->assertTrue($result); $this->assertTrue($result);
$this->assertCount(1, $piggyBank->piggyBankEvents()->get());
} }
/**
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @covers FireflyIII\Handlers\Events\ConnectJournalToPiggyBank::handle
*/
public function testWithRepetitionReversed()
{
FactoryMuffin::create('FireflyIII\Models\TransactionType');
FactoryMuffin::create('FireflyIII\Models\TransactionType');
$user = FactoryMuffin::create('FireflyIII\User');
$this->be($user);
$journal = FactoryMuffin::create('FireflyIII\Models\TransactionJournal');
$piggyBank = FactoryMuffin::create('FireflyIII\Models\PiggyBank');
$account1 = FactoryMuffin::create('FireflyIII\Models\Account');
$account2 = FactoryMuffin::create('FireflyIII\Models\Account');
$account1->user_id = $user->id;
$account2->user_id = $user->id;
$piggyBank->account_id = $account1->id;
$account1->save();
$account2->save();
$piggyBank->save();
$start = clone $journal->date;
$end = clone $journal->date;
$start->subDay();
$end->addDay();
PiggyBankRepetition::create(
[
'piggy_bank_id' => $piggyBank->id,
'startdate' => $start->format('Y-m-d'),
'targetdate' => $end->format('Y-m-d'),
'currentamount' => 0,
]
);
$event = new JournalCreated($journal, $piggyBank->id);
$class = new ConnectJournalToPiggyBank();
$result = $class->handle($event);
$this->assertTrue($result);
$this->assertCount(1, $piggyBank->piggyBankEvents()->get());
}
} }