kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-31 02:36:28 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage and quality

Browse Source
This commit is contained in:
James Cole
2019-06-16 13:16:46 +02:00
parent 1ce1a84c9e
commit 72c0d7a874
34 changed files with 3211 additions and 2524 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/Api/V1/Controllers/UserControllerTest.php
View File

@@ -61,7 +61,7 @@ class UserControllerTest extends TestCase
public function testStoreBasic(): void
{
$data = [
'email' => 'some_new@user' . random_int(1, 10000) . '.com',
'email' => 'some_new@user' . $this->randomInt() . '.com',
];
// mock
@@ -91,7 +91,7 @@ class UserControllerTest extends TestCase
public function testStoreBasicJson(): void
{
$data = [
'email' => 'some_new@user' . random_int(1, 10000) . '.com',
'email' => 'some_new@user' . $this->randomInt() . '.com',
'blocked' => true,
'blocked_code' => 'email_changed',
];
@@ -185,11 +185,11 @@ class UserControllerTest extends TestCase
public function testUpdate(): void
{
// create a user first:
$user = User::create(['email' => 'some@newu' . random_int(1, 10000) . 'ser.nl', 'password' => 'hello', 'blocked' => 0]);
$user = User::create(['email' => 'some@newu' . $this->randomInt() . 'ser.nl', 'password' => 'hello', 'blocked' => 0]);
// data:
$data = [
'email' => 'some-new@email' . random_int(1, 10000) . '.com',
'email' => 'some-new@email' . $this->randomInt() . '.com',
'blocked' => 0,
];
@@ -220,11 +220,11 @@ class UserControllerTest extends TestCase
public function testUpdateJson(): void
{
// create a user first:
$user = User::create(['email' => 'some@newu' . random_int(1, 10000) . 'ser.nl', 'password' => 'hello', 'blocked' => 0]);
$user = User::create(['email' => 'some@newu' . $this->randomInt() . 'ser.nl', 'password' => 'hello', 'blocked' => 0]);
// data:
$data = [
'email' => 'some-new@email' . random_int(1, 10000) . '.com',
'email' => 'some-new@email' . $this->randomInt() . '.com',
'blocked' => 0,
];