kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-17 09:51:40 +00:00
Code Issues Projects Releases Wiki Activity

Clean up some code.

Browse Source
This commit is contained in:
James Cole
2016-03-29 16:13:36 +02:00
parent ab4616a3ad
commit 6fdfec3967
3 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/Http/Controllers/Chart/BudgetController.php
View File

@@ -310,7 +310,7 @@ class BudgetController extends Controller
$cache->addProperty('budget'); $cache->addProperty('budget');
$cache->addProperty('year'); $cache->addProperty('year');
if ($cache->has()) { if ($cache->has()) {
//return Response::json($cache->get()); // @codeCoverageIgnore return Response::json($cache->get()); // @codeCoverageIgnore
} }
$budgetInformation = $repository->getBudgetsAndExpensesPerMonth($accounts, $start, $end); $budgetInformation = $repository->getBudgetsAndExpensesPerMonth($accounts, $start, $end);
@@ -328,9 +328,6 @@ class BudgetController extends Controller
$row = [clone $start]; $row = [clone $start];
$dateFormatted = $start->format('Y-m'); $dateFormatted = $start->format('Y-m');
//echo $start,' '.$month.'<br>';
// each budget, check if there is an entry for this month: // each budget, check if there is an entry for this month:
/** @var array $row */ /** @var array $row */
foreach ($budgetInformation as $budgetRow) { foreach ($budgetInformation as $budgetRow) {

2
app/Validation/FireflyValidator.php
View File

@@ -54,7 +54,7 @@ class FireflyValidator extends Validator
* *
* @return bool * @return bool
*/ */
public function validate2faCode($attribute, $value, $parameters): bool public function validate2faCode($attribute, $value): bool
{ {
if (!is_string($value) || is_null($value) || strlen($value) <> 6) { if (!is_string($value) || is_null($value) || strlen($value) <> 6) {
return false; return false;

2
tests/TestCase.php
View File

@@ -36,8 +36,6 @@ class TestCase extends Illuminate\Foundation\Testing\TestCase
// set period to match? // set period to match?
} }
// custom is a weird range
// (20 days):
if ($range === 'custom') { if ($range === 'custom') {
$this->session( $this->session(
[ [