kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-22 12:11:19 +00:00
Code Issues Projects Releases Wiki Activity

Code cleanup

Browse Source
This commit is contained in:
James Cole
2019-08-17 10:54:16 +02:00
parent 1974d5f1e3
commit 6d1bfd3956
11 changed files with 31 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/Unit/Support/Import/JobConfiguration/Spectre/ChooseLoginHandlerTest.php
View File

@@ -142,9 +142,9 @@ class ChooseLoginHandlerTest extends TestCase
public function testConfigureJobCustomer(): void
{
// fake Spectre customer:
$fakeCustomerPreference = new Preference;
$fakeCustomerPreference->name = 'spectre_customer';
$fakeCustomerPreference->data = [
$fakePref = new Preference;
$fakePref->name = 'spectre_customer';
$fakePref->data = [
'id' => 1,
'identifier' => 'fake',
'secret' => 'Dumbledore dies',
@@ -167,7 +167,7 @@ class ChooseLoginHandlerTest extends TestCase
// should try to grab customer from preferences:
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'spectre_customer', null])
->andReturn($fakeCustomerPreference)->once();
->andReturn($fakePref)->once();
// mock stuff
$ctRequest = $this->mock(CreateTokenRequest::class);

2
tests/Unit/Support/Import/Placeholder/ImportTransactionTest.php
View File

@@ -35,6 +35,8 @@ use Tests\TestCase;
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.TooManyMethods)
* @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
*/
class ImportTransactionTest extends TestCase
{

18
tests/Unit/Support/Import/Routine/Bunq/StageNewHandlerTest.php
View File

@@ -85,7 +85,7 @@ class StageNewHandlerTest extends TestCase
// create fake bunq object:
$setting = new MonetaryAccountSetting(null, null, null);
$mab = new BunqMonetaryAccountBank('EUR', 'Some descr', null, null, null, null, null, null, null, null);
$ma = new BunqMonetaryAccount;
$monAcc = new BunqMonetaryAccount;
$alias = new Pointer('a', 'b', null);
@@ -96,10 +96,10 @@ class StageNewHandlerTest extends TestCase
$setting->setColor('FFFFFF');
$mab->setSetting($setting);
$mab->setAlias([$alias]);
$ma->setMonetaryAccountBank($mab);
$monAcc->setMonetaryAccountBank($mab);
// response list.
$list = new BunqResponseMonetaryAccountList([$ma], []);
$list = new BunqResponseMonetaryAccountList([$monAcc], []);
$expectedConfig = [
'accounts' => [
@@ -172,7 +172,7 @@ class StageNewHandlerTest extends TestCase
// create fake bunq object:
$setting = new MonetaryAccountSetting(null, null, null);
$maj = new MonetaryAccountJoint('EUR', [], 'Some descr', null, null, null, null, null, null, null, null);
$ma = new BunqMonetaryAccount;
$monAcc = new BunqMonetaryAccount;
$alias = new Pointer('a', 'b', null);
$labelUser = new LabelUser('x', 'James', 'NL');
$coOwner = new CoOwner($alias);
@@ -186,11 +186,11 @@ class StageNewHandlerTest extends TestCase
$maj->setSetting($setting);
$maj->setAlias([$alias]);
$maj->setAllCoOwner([$coOwner]);
$ma->setMonetaryAccountJoint($maj);
$monAcc->setMonetaryAccountJoint($maj);
$coOwner->setAlias($labelUser);
// response list.
$list = new BunqResponseMonetaryAccountList([$ma], []);
$list = new BunqResponseMonetaryAccountList([$monAcc], []);
$expectedConfig = [
'accounts' => [
@@ -264,7 +264,7 @@ class StageNewHandlerTest extends TestCase
// create fake bunq object:
$setting = new MonetaryAccountSetting(null, null, null);
$mal = new MonetaryAccountLight('EUR', 'Some descr', null, null, null, null, null, null, null, null);
$ma = new BunqMonetaryAccount;
$monAcc = new BunqMonetaryAccount;
$alias = new Pointer('a', 'b', null);
@@ -275,10 +275,10 @@ class StageNewHandlerTest extends TestCase
$setting->setColor('FFFFFF');
$mal->setSetting($setting);
$mal->setAlias([$alias]);
$ma->setMonetaryAccountLight($mal);
$monAcc->setMonetaryAccountLight($mal);
// response list.
$list = new BunqResponseMonetaryAccountList([$ma], []);
$list = new BunqResponseMonetaryAccountList([$monAcc], []);
$expectedConfig = [
'accounts' => [

6
tests/Unit/Support/Import/Routine/File/MappedValuesValidatorTest.php
View File

@@ -125,14 +125,14 @@ class MappedValuesValidatorTest extends TestCase
}
/**
* @param int $id
* @param int $objectId
*
* @return stdClass
*/
private function objectWithId(int $id): stdClass
private function objectWithId(int $objectId): stdClass
{
$obj = new stdClass();
$obj->id = $id;
$obj->id = $objectId;
return $obj;
}