Various code cleanup [skip ci]

This commit is contained in:
James Cole
2016-10-22 09:39:31 +02:00
parent 12a6a61100
commit 5d9b68c3e7
9 changed files with 26 additions and 83 deletions

View File

@@ -126,7 +126,7 @@ class SplitController extends Controller
*/
public function update(Request $request, JournalRepositoryInterface $repository, TransactionJournal $journal)
{
$data = $this->arrayFromInput($request, $journal);
$data = $this->arrayFromInput($request);
$journal = $repository->updateSplitJournal($journal, $data);
// save attachments:
@@ -158,18 +158,17 @@ class SplitController extends Controller
/**
* @param Request $request
* @param TransactionJournal $journal
*
* @return array
*/
private function arrayFromInput(Request $request, TransactionJournal $journal): array
private function arrayFromInput(Request $request): array
{
$array = [
'journal_description' => $request->get('journal_description'),
'journal_source_account_id' => $request->get('journal_source_account_id'),
'journal_source_account_name' => $request->get('journal_source_account_name'),
'journal_destination_account_id' => $request->get('journal_destination_account_id'),
'currency_id' => $request->get('currency_id'),
'currency_id' => $request->get('currency_id'),
'what' => $request->get('what'),
'date' => $request->get('date'),
// all custom fields: