From 2fa927266f90263e9617ffa621209c0ff1a3d3e9 Mon Sep 17 00:00:00 2001
From: James Cole <james@firefly-iii.org>
Date: Sun, 20 Jun 2021 18:39:15 +0200
Subject: [PATCH] Fix #4864 and relatred issues.

---
 frontend/src/components/transactions/Create.vue          | 9 ++++++++-
 frontend/src/components/transactions/Index.vue           | 8 ++++----
 frontend/src/components/transactions/TransactionBill.vue | 4 ----
 .../src/components/transactions/TransactionNotes.vue     | 7 +------
 .../src/components/transactions/TransactionPiggyBank.vue | 6 +-----
 frontend/src/components/transactions/TransactionTags.vue | 5 -----
 6 files changed, 14 insertions(+), 25 deletions(-)

diff --git a/frontend/src/components/transactions/Create.vue b/frontend/src/components/transactions/Create.vue
index 338221a7b0..f29b53103c 100644
--- a/frontend/src/components/transactions/Create.vue
+++ b/frontend/src/components/transactions/Create.vue
@@ -195,7 +195,7 @@ export default {
     /**
      * Grabbed from the store.
      */
-    ...mapGetters('transactions/create', ['transactionType', 'transactions', 'groupTitle','defaultErrors']),
+    ...mapGetters('transactions/create', ['transactionType', 'transactions', 'groupTitle', 'defaultErrors']),
     ...mapGetters('root', ['listPageSize'])
   },
   watch: {
@@ -713,13 +713,20 @@ export default {
             let current = array.tags[i];
             if (typeof current === 'object' && null !== current) {
               currentSplit.tags.push(current.text);
+              console.log('Add tag "' + current.text + '" from object.');
+              continue;
             }
             if (typeof current === 'string') {
               currentSplit.tags.push(current);
+              console.log('Add tag "' + current + '" from string.');
+              continue;
             }
+            console.log('Is neither.');
           }
         }
       }
+      console.log('Current split tags is now: ');
+      console.log(currentSplit.tags);
 
       // bills and piggy banks
       if (0 !== array.piggy_bank_id) {
diff --git a/frontend/src/components/transactions/Index.vue b/frontend/src/components/transactions/Index.vue
index 19ea5ba9d7..8d1cd9aa6d 100644
--- a/frontend/src/components/transactions/Index.vue
+++ b/frontend/src/components/transactions/Index.vue
@@ -50,10 +50,10 @@
       </div>
     </div>
     <div class="row">
-      <div class="col-lg-8 col-md-12 col-sm-12 col-xs-12">
+      <div class="col-lg-10 col-md-8 col-sm-12 col-xs-12">
         <div class="card">
           <div class="card-body p-0">
-            <b-table id="my-table" striped hover responsive="md" primary-key="key" :no-local-sorting="false"
+            <b-table id="my-table" small striped hover responsive="md" primary-key="key" :no-local-sorting="false"
                      :items="transactionRows"
                      :fields="fields"
                      :per-page="perPage"
@@ -75,7 +75,7 @@
                 </span>
               </template>
               <template #cell(description)="data">
-                <span><span class="fas fa-angle-right" v-if="data.item.split && data.item.split_parent !== null"></span></span>
+                <span class="fas fa-angle-right" v-if="data.item.split && data.item.split_parent !== null"></span>
                 <a :class="false === data.item.active ? 'text-muted' : ''" :href="'./transactions/show/' + data.item.id" :title="data.value">{{
                     data.value
                   }}</a>
@@ -139,7 +139,7 @@
           </div>
         </div>
       </div>
-      <div class="col-lg-4">
+      <div class="col-lg-2 col-md-4">
         <div class="card">
           <div class="card-body">
             Box previous periods
diff --git a/frontend/src/components/transactions/TransactionBill.vue b/frontend/src/components/transactions/TransactionBill.vue
index 5702326588..1bb269247b 100644
--- a/frontend/src/components/transactions/TransactionBill.vue
+++ b/frontend/src/components/transactions/TransactionBill.vue
@@ -50,7 +50,6 @@ export default {
     return {
       billList: [],
       bill: this.value,
-      emitEvent: true
     }
   },
   created() {
@@ -93,10 +92,7 @@ export default {
       this.bill = value;
     },
     bill: function (value) {
-      if (true === this.emitEvent) {
         this.$emit('set-field', {field: 'bill_id', index: this.index, value: value});
-      }
-      this.emitEvent = true;
     }
   },
 }
diff --git a/frontend/src/components/transactions/TransactionNotes.vue b/frontend/src/components/transactions/TransactionNotes.vue
index 686ed7a601..6bb594d609 100644
--- a/frontend/src/components/transactions/TransactionNotes.vue
+++ b/frontend/src/components/transactions/TransactionNotes.vue
@@ -43,7 +43,6 @@ export default {
     return {
       notes: this.value,
       availableFields: this.customFields,
-      emitEvent: true
     }
   },
   computed: {
@@ -56,17 +55,13 @@ export default {
   },
   watch: {
     value: function (value) {
-      this.emitEvent = false;
       this.notes = value;
     },
     customFields: function (value) {
       this.availableFields = value;
     },
     notes: function (value) {
-      if (true === this.emitEvent) {
-        this.$emit('set-field', {field: 'notes', index: this.index, value: value});
-      }
-      this.emitEvent = true;
+      this.$emit('set-field', {field: 'notes', index: this.index, value: value});
     }
   }
 }
diff --git a/frontend/src/components/transactions/TransactionPiggyBank.vue b/frontend/src/components/transactions/TransactionPiggyBank.vue
index a696e2a399..8af0a74a1c 100644
--- a/frontend/src/components/transactions/TransactionPiggyBank.vue
+++ b/frontend/src/components/transactions/TransactionPiggyBank.vue
@@ -51,7 +51,6 @@ export default {
     return {
       piggyList: [],
       piggy_bank_id: this.value,
-      emitEvent: true
     }
   },
   created() {
@@ -90,13 +89,10 @@ export default {
   },
   watch: {
     value: function (value) {
-      this.emitEvent = false;
       this.piggy_bank_id = value;
     },
     piggy_bank_id: function (value) {
-      if (true === this.emitEvent) {
-        this.$emit('set-field', {field: 'piggy_bank_id', index: this.index, value: value});
-      }
+      this.$emit('set-field', {field: 'piggy_bank_id', index: this.index, value: value});
       this.emitEvent = true;
     }
   }
diff --git a/frontend/src/components/transactions/TransactionTags.vue b/frontend/src/components/transactions/TransactionTags.vue
index d3a4782931..f5ee3f41aa 100644
--- a/frontend/src/components/transactions/TransactionTags.vue
+++ b/frontend/src/components/transactions/TransactionTags.vue
@@ -58,7 +58,6 @@ export default {
       currentTag: '',
       updateTags: true, // the idea is that this is always true, except when the tags-function sets the value.
       tagList: this.value,
-      emitEvent: true
     };
   },
   created() {
@@ -74,15 +73,11 @@ export default {
   watch: {
     'currentTag': 'initItems',
     value: function (value) {
-      this.emitEvent = false;
       this.tagList = value;
     },
     tagList: function (value) {
       // console.log('watch tagList');
-      if (true === this.emitEvent) {
         this.$emit('set-field', {field: 'tags', index: this.index, value: value});
-      }
-      this.emitEvent = true;
       this.updateTags = false;
       this.tags = value;
     },