kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-18 10:16:49 +00:00
Code Issues Projects Releases Wiki Activity

Fix #4663

Browse Source
This commit is contained in:
James Cole
2021-04-15 06:15:17 +02:00
parent 577dcfa938
commit 0ea22269a0
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Services/Internal/Update/JournalUpdateService.php
View File

@@ -292,7 +292,7 @@ class JournalUpdateService
$validator->setTransactionType($expectedType); $validator->setTransactionType($expectedType);
$validator->setUser($this->transactionJournal->user); $validator->setUser($this->transactionJournal->user);
$validator->source = $this->getValidSourceAccount(); $validator->source = $this->getValidSourceAccount();
$result = $validator->validateDestination($destId, $destName, null); $result = $validator->validateDestination($destId, $destName, null);
Log::debug(sprintf('hasValidDestinationAccount(%d, "%s") will return %s', $destId, $destName, var_export($result, true))); Log::debug(sprintf('hasValidDestinationAccount(%d, "%s") will return %s', $destId, $destName, var_export($result, true)));
// TODO typeOverrule: the account validator may have another opinion on the transaction type. // TODO typeOverrule: the account validator may have another opinion on the transaction type.
@@ -527,6 +527,10 @@ class JournalUpdateService
Log::debug('Will update budget.'); Log::debug('Will update budget.');
$this->storeBudget($this->transactionJournal, new NullArrayObject($this->data)); $this->storeBudget($this->transactionJournal, new NullArrayObject($this->data));
} }
// is transfer? remove budget
if (TransactionType::TRANSFER === $this->transactionJournal->transactionType->type) {
$this->transactionJournal->budgets()->sync([]);
}
} }
/** /**