Fix some scrutiniser issues.

This commit is contained in:
James Cole
2017-01-14 19:43:33 +01:00
parent 0b5cab99cf
commit 08ac27cccf
14 changed files with 44 additions and 28 deletions

View File

@@ -24,6 +24,7 @@ use FireflyIII\Models\ExportJob;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Repositories\ExportJob\ExportJobRepositoryInterface;
use FireflyIII\Repositories\ExportJob\ExportJobRepositoryInterface as EJRI;
use Illuminate\Http\Response as LaravelResponse;
use Preferences;
use Response;
use View;
@@ -73,8 +74,9 @@ class ExportController extends Controller
$job->change('export_downloaded');
return response($content, 200)
/** @var LaravelResponse $response */
$response = response($content, 200);
$response
->header('Content-Description', 'File Transfer')
->header('Content-Type', 'application/octet-stream')
->header('Content-Disposition', 'attachment; filename=' . $quoted)
@@ -85,6 +87,8 @@ class ExportController extends Controller
->header('Pragma', 'public')
->header('Content-Length', strlen($content));
return $response;
}
/**
@@ -128,8 +132,7 @@ class ExportController extends Controller
* @param AccountRepositoryInterface $repository
* @param EJRI $jobs
*
* @return string
*
* @return \Illuminate\Http\JsonResponse
*/
public function postIndex(ExportFormRequest $request, AccountRepositoryInterface $repository, EJRI $jobs)
{