53 Commits

Author SHA1 Message Date
Neeraj Gupta
2cade6f271 [mob] Refactor 2025-01-29 17:13:21 +05:30
Neeraj Gupta
c64af87e33 [mob] Refactor 2025-01-29 13:52:12 +05:30
Neeraj Gupta
e9ed423094 Lint fixes 2025-01-21 14:21:13 +05:30
Simon Dubrulle
193bef6927 extracted most remaining strings + fixed issue where 'magic' items would always show in english in hierarchical search 2024-11-22 12:22:10 +01:00
ashilkn
899c1d7041 [mob][photos] Remove unnecessary check 2024-11-07 22:55:35 +05:30
ashilkn
219ff7d2e9 Revert "[mob][photos] Add option to make 'only them' filter work a little different only for testing, for feedback on which option is better"
This reverts commit ebae813ee37fde8132ea5e11312862176adf0cc2.
2024-11-07 22:34:09 +05:30
ashilkn
0815bfd7b7 [mob][photos] Use better name 2024-11-07 15:12:24 +05:30
ashilkn
84d7a37789 [mob][photos] Extract string and use workaround for avoiding having context as a long lived object 2024-11-06 18:57:30 +05:30
ashilkn
64b113bd21 [mob][photos] Refactor 2024-11-06 15:21:45 +05:30
ashilkn
39a3a9a8fa [mob][photos] Avoid recomputing results of 'Only them' filter if already available 2024-11-05 22:29:55 +05:30
ashilkn
ebae813ee3 [mob][photos] Add option to make 'only them' filter work a little different only for testing, for feedback on which option is better 2024-11-05 22:27:38 +05:30
ashilkn
f09005ed95 [mob][photos] Make filtering of 'Only them' filter faster by making one db query instead of two and log and handle any errors when filtering using the 'Only them' filter 2024-11-05 21:01:35 +05:30
ashilkn
472bf48b42 [mob][photos] Remove face IDs that aren't associated with any cluster from getting added to the 'Only them' filter results 2024-11-05 10:10:59 +05:30
ashilkn
fb9b3543e0 [mob][photos] Remove stale code 2024-11-04 20:22:39 +05:30
ashilkn
b2da30e207 [mob][photos] Show 'Only them' filter in recommendations right after a person screen is opened, even when there are no filters selected 2024-11-04 19:19:52 +05:30
ashilkn
da38c3e9f5 [mob][photos] Fix missing files in hierarchical search when searching over an archived album 2024-10-30 15:40:33 +05:30
ashilkn
862e84e6b2 [mob][photos] Make 'only them' filter working, showing filtered files in gallery 2024-10-30 14:33:08 +05:30
ashilkn
f753779860 [mob][photos] Create only them filter and add it to recommendations on a condition 2024-10-29 17:26:18 +05:30
ashilkn
322c729c13 [mob][photos] Curate slightly better recommendations in app bar
Before, the recommendations were only based on relevance. Now the recommendations will be mostly relevant and a bit more diverse when it comes to type of filter
2024-10-26 18:50:24 +05:30
ashilkn
a29f9db35d [mob][photos] Show loading state in gallery from when a filter is applied to when all computation related to it finishes 2024-10-25 09:10:51 +05:30
ashilkn
53e7bbac78 [mob][photos] Chore 2024-10-24 22:15:04 +05:30
ashilkn
8c708530ef [mob][photos] Perf improvements to hierarchical search
Normal search and hierarchical search needs slightly different set of files. Refactored code in such a way that the elements in both these lists are references of a elements in a list of all files and hence reducing the memory needed for search and hierarchical search combined. Files used for hierarchical search contain only uploaded files now, rather than mix of uploaded and un-uploaded, reducing iterations required for hierarchical search
2024-10-24 17:17:50 +05:30
ashilkn
d45cb08fec [mob][photos] Remove duplicates and don't show files in ignored collections in Hierarchical search gallery 2024-10-24 11:52:44 +05:30
ashilkn
2ec911da06 [mob][photos] Fix files in group in HierarchicalSearchGallery not ordered by creation time + reduce iterations 2024-10-23 21:41:42 +05:30
ashilkn
802ba55016 [mob][photos] Group filter recommendations by type in appbar 2024-10-23 18:44:35 +05:30
ashilkn
7ed11779bd [mob][photos] Show a gallery's TopLevelGenericFiter too in all filters view 2024-10-23 17:58:17 +05:30
ashilkn
9722cd5d67 [mob][photos] Create a bigger view that shows all applied and recommended filters (bottom sheet) and make changes related to it 2024-10-22 22:52:43 +05:30
ashilkn
1701311be3 [mob][photos] Minor fix 2024-10-22 12:47:10 +05:30
ashilkn
f63e8b51d9 [mob][photos] Use service locators where ever necessary 2024-10-19 22:44:08 +05:30
ashilkn
5111b98839 [mob][photos] Pass matchedUploadedIDs to MagicFilter right when recommendations are curated for MagicFilter to work when applied 2024-10-19 20:24:08 +05:30
ashilkn
f66e49313d [mob][photos] Show magic filter recommendations for a gallery using magic cache used for the discovery section 2024-10-19 19:26:43 +05:30
ashilkn
0fc63396b7 [mob][photos] Chore 2024-10-18 20:03:32 +05:30
ashilkn
c7a692cb4d [mob][photos] Fix face thumbnail not appearing when filter is applied 2024-10-18 07:25:24 +05:30
ashilkn
288e987246 [mob][photos] Add more logging in filtering files 2024-10-18 07:13:48 +05:30
ashilkn
e616071395 [mob][photos] Optimize getting uploaded file IDs associated with personID and clusterID when applying face filters 2024-10-17 21:20:40 +05:30
ashilkn
2f54acab58 [mob][photos] Make face filtering work (yet to be optimized for performance) 2024-10-17 19:14:24 +05:30
ashilkn
0ef03389ab [mob][photos] Pass FaceFilter.name as null if face name is not available (when personId is null) instead of passing clusterID 2024-10-17 09:16:36 +05:30
ashilkn
f5cadb3b7a [mob][photos] Curate face filters and show in recommendations 2024-10-10 19:50:38 +05:30
ashilkn
f1535f901f [mob][photos] Pass better string for FileTypeFilter. Also, do it in such a way that name() of HierarchicalSearchFilter doesn't need a BuildContext parameter 2024-10-07 17:04:16 +05:30
ashilkn
5f2cc6f6c3 [mob][photos] Add initialFilter in search results page depending on the type of search result passed 2024-10-07 16:26:05 +05:30
ashilkn
fac18333ce [mob][photos] Improve performance when adding/removing filters during hierarchical search by using cached results of applied filters instead of iterating through all filters and files 2024-10-05 19:45:55 +05:30
ashilkn
bbc894cfda [mob][photos] Add contacts filter in hierarchical search 2024-10-05 16:46:12 +05:30
ashilkn
e2897b7d18 [mob][photos] Curate location filters in isolate 2024-10-04 15:31:16 +05:30
ashilkn
18a22c8014 [mob][photos] Handle and log failures in curating and applying filters 2024-10-03 07:51:15 +05:30
ashilkn
2c2c7f6c9e [mob][photos] Fix null check used on null value exception + refactor filtering of files 2024-10-03 07:47:05 +05:30
ashilkn
6aec2c5718 [mob][photos] Curate both album and fileType filters and add all to applied filters at once 2024-10-03 07:22:19 +05:30
ashilkn
369bdc8f4c [mob][photos] Create function to curate file type filters 2024-10-03 07:08:04 +05:30
ashilkn
a105195481 [mob][photos] Make matchedUploadedIDs a property of HierarchicalSearchFilter so that it's a property of all filters that extend it 2024-10-02 10:49:23 +05:30
ashilkn
2292146706 [mob][photos] Refactor 2024-10-01 15:58:48 +05:30
ashilkn
60c718c7ed [mob][photos] Move filtering logic outside of gallery to reduce clutter in gallery file 2024-09-30 16:38:54 +05:30