ashilkn
9de634ab8b
[mob][photos] Use an app bar that occupies less space on UI in 'all' section of people section compared to the app bar used in 'all' screen of other sections
2024-11-18 10:31:05 +05:30
ashilkn
58887ce044
[mob][photos] Make 'all' screen of people section more similar to 'all' screen of other sections
2024-11-18 10:25:07 +05:30
ashilkn
8ba65c599a
[mob][photos] Fix SafeArea widget breaking the item size logic on 'all' screen of people section
2024-11-18 10:00:01 +05:30
laurenspriem
12fc4816c7
[mob][photos] More refactor
2024-11-16 19:00:50 +05:30
laurenspriem
826383ccdf
[mob][photos] Refactor face thumbnail generation
2024-11-16 18:43:24 +05:30
ashilkn
392ec34f25
[mob][photos] Remove hero animation from People section because when it's enabled, there is a UI glitch because of an issue in flutter
...
https://github.com/flutter/flutter/issues/47991
2024-11-15 20:57:15 +05:30
ashilkn
102929a5d6
[mob][photos] Decrease the chances of hero animation not working between faces in 'All' screen of People and People section when going back to search section from 'All' screen
2024-11-15 17:43:32 +05:30
ashilkn
27d5ef2bc0
[mob][photos] Fix alignment of faces in People section
2024-11-15 15:31:53 +05:30
Neeraj Gupta
179e586671
[mob] Refactor
2024-11-15 15:18:29 +05:30
Neeraj Gupta
92f6d027db
[mob] Clean up
2024-11-15 15:13:23 +05:30
ashilkn
39252122ef
[mob][photos] Show all faces in 'All' section of faces
2024-11-15 13:35:41 +05:30
ashilkn
184323429a
[mob][photos] Create new 'All' page for people section
2024-11-15 13:22:29 +05:30
ashilkn
e9923fbf44
[mob][photos] Change UI of PersonSearchExample widget
2024-11-14 17:07:38 +05:30
Neeraj Gupta
3f6f031cfe
Merge branch 'main' into save_contact
2024-11-14 11:55:50 +05:30
laurenspriem
822aa7fcd4
[mob][photos] Make sure user can add back rejected faces
2024-11-13 14:38:51 +05:30
Prateek Sunal
bbfa447e42
fix: source preview file as videoplayer's input
2024-11-11 23:55:33 +05:30
Prateek Sunal
c83bd41dae
Merge remote-tracking branch 'origin/main' into mobile-preview-video
2024-11-11 22:01:30 +05:30
Ashil
d25b1f7b65
[mob][photos] Concatenate strings more efficiently ( #3985 )
...
## Description
If number of iterations are high, concatenating a list of values to a
string using `str1 += str2` can block the UI thread.
Using `List.join()` is a much more efficient way to do this.
2024-11-09 09:34:49 +05:30
ashilkn
1e9188f510
[mob][photos] Replace string concatenation happening in loop using '+' with more efficient alternative of by using 'List.join(). If number of iterations are very large, using '+' for concatenation can block the UI thread'
2024-11-08 21:38:33 +05:30
ashilkn
10f9638f24
[mob][photos] Chore
2024-11-08 18:30:29 +05:30
ashilkn
8965f1cd09
[mob][photos] Fix: Cast not working on android (Pair with PIN option)
2024-11-08 18:27:35 +05:30
ashilkn
65131a15ef
[mob][photos] Fix
2024-11-07 23:59:18 +05:30
ashilkn
25b26ec303
[mob][photos] Workaround for a UX issue
2024-11-07 23:31:48 +05:30
ashilkn
88440400c2
[mob][photos] Fix loading state not appearing when the first filter is added in hierarchical search
2024-11-07 23:29:24 +05:30
ashilkn
88f613187d
Revert "[mob] Render people section in GridView ( #3958 )"
...
This reverts commit 7a99c8be63f1e7c0bec9ec8fa69158acd3147cc7, reversing
changes made to 287d4b00e1f8b11b214dfc22633847d997ebc77f.
2024-11-07 23:15:17 +05:30
ashilkn
65e8ff4da8
[mob][photos] Resolve merge conflicts and merge main
2024-11-07 22:21:44 +05:30
ashilkn
9becee9a85
[mob][photos] Remove unnecessary clipping
2024-11-07 22:09:03 +05:30
ashilkn
52663ae218
[mob][photos] Add comment
2024-11-07 22:00:34 +05:30
ashilkn
c5aecaf501
[mob][photos] Remove unused method
2024-11-07 21:54:11 +05:30
ashilkn
655d9602e0
[mob][photos] Dispose all notifiers of SearchFilterDataProvider after use
2024-11-07 21:47:58 +05:30
ashilkn
b83b7ad295
[mob][photos] Use better names
2024-11-07 20:23:34 +05:30
ashilkn
ae3b784463
[mob][photos] Improvements on PeopleBanner shown in hierarchical search
2024-11-07 19:59:14 +05:30
ashilkn
93fd05818a
[mob][photos] Show 'Add a name' banner if an unnamed cluster is applied in hierarchical search
...
If there are multiple applied unnamed clusters, the banner will be shown for the first one
2024-11-07 18:35:21 +05:30
ashilkn
68fa429611
[mob][photos] Make PeopleBanner UI better and minimal
2024-11-07 18:07:00 +05:30
Neeraj Gupta
3a09d50972
Merge branch 'main' into mobile-preview-video
2024-11-07 17:52:08 +05:30
ashilkn
4b2a845fd0
[mob][photos] Give a more subtle shadow for PeopleBanner
2024-11-07 17:35:11 +05:30
ashilkn
f2e99d5efd
[mob][photos] Keep the galleryType as GalleryType.peopleTag when an 'Only them' filter is applied when, the initial filter is a face filter so that the selection option are of the inital face filter's
...
Needed to write extra code to make it work for 'Only them' face since the current logic checks if inital filter is in applied list, and if yes keep the gallery type unchanged and if not, change gallery type to GalleryType.searchResults. Since an 'Only them' filter is not exactly the same as a Face filter, had to write more code to handle this case since the 'Only them' filter can have the inital Face filter in it
2024-11-06 22:03:40 +05:30
ashilkn
d355d4c1f0
[mob][photos] Fix null check operator used on null value exception right after adding name to a person
2024-11-06 21:39:14 +05:30
ashilkn
042cbdeee7
[mob][photos] Refactor
2024-11-06 21:16:24 +05:30
ashilkn
64b113bd21
[mob][photos] Refactor
2024-11-06 15:21:45 +05:30
Neeraj Gupta
6e86c7dff0
[mob] Show people in grid view
2024-11-06 14:25:42 +05:30
Neeraj Gupta
0e27e1c928
[mob] Lint suggestion
2024-11-06 13:38:23 +05:30
Neeraj Gupta
fad4077f76
[mob] Separate all page for people
2024-11-06 13:37:50 +05:30
Neeraj Gupta
6a878b165d
[mob] Lint
2024-11-06 12:38:36 +05:30
ashilkn
bdc80c8f97
Merge branch 'main' into hierarchical_search
2024-11-05 22:31:42 +05:30
ashilkn
724b9620be
[mob][photos] chore
2024-11-05 19:45:29 +05:30
ashilkn
30cde90a68
[mob][photos] Only add initialGalleryFilter to filters to avoid in recommendations list when there are no applied filters
...
This resolves a bug: If 'A' is the initialGalleryFilter and a filter 'B' is applied (in this state both A and B filters are applied), and then the filter 'A' is removed, in recommendations, filter 'A' is not recommended since it's passed as a filter to avoid in recommendations
2024-11-05 16:18:49 +05:30
Neeraj Gupta
fb4c1b206d
[mob] Basic skeleton to save person
2024-11-05 11:47:23 +05:30
ashilkn
b036079249
[mob][photos] Do not show any face filters in recommendations when an 'Only them' filter is applied
2024-11-04 17:49:20 +05:30
Laurens Priem
59f7b316c3
Copy ( #3930 )
...
Copy change
2024-11-04 16:04:17 +05:30
